Added specifying types to cast handlers

Author: ondrejmirtes

src/Analyser/Generator/ExprHandler/CastBoolHandler.php

@@ -4,6 +4,9 @@
 
 use Generator;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\BinaryOp\Equal;
+use PhpParser\Node\Expr\ConstFetch;
+use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt;
 use PHPStan\Analyser\ExpressionContext;
 use PHPStan\Analyser\Generator\ExprAnalysisRequest;
@@ -35,6 +38,8 @@ public function analyseExpr(
 	{
 		$exprResult = yield new ExprAnalysisRequest($stmt, $expr->expr, $scope, $context->enterDeep(), $alternativeNodeCallback);
 
+		$equalExprResult = yield ExprAnalysisRequest::createNoopRequest(new Equal($expr->expr, new ConstFetch(new FullyQualified('true'))), $scope);
+
 		return new ExprAnalysisResult(
 			$exprResult->type->toBoolean(),
 			$exprResult->nativeType->toBoolean(),
@@ -43,8 +48,8 @@ public function analyseExpr(
 			isAlwaysTerminating: false,
 			throwPoints: [],
 			impurePoints: [],
-			specifiedTruthyTypes: new SpecifiedTypes(),
-			specifiedFalseyTypes: new SpecifiedTypes(),
+			specifiedTruthyTypes: $equalExprResult->specifiedTruthyTypes->setRootExpr($expr),
+			specifiedFalseyTypes: $equalExprResult->specifiedFalseyTypes->setRootExpr($expr),
 			specifiedNullTypes: new SpecifiedTypes(),
 		);
 	}

src/Analyser/Generator/ExprHandler/CastDoubleHandler.php

@@ -4,6 +4,9 @@
 
 use Generator;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\BinaryOp\NotEqual;
+use PhpParser\Node\Scalar\Float_;
+use PhpParser\Node\Scalar\Int_ as ScalarInt;
 use PhpParser\Node\Stmt;
 use PHPStan\Analyser\ExpressionContext;
 use PHPStan\Analyser\Generator\ExprAnalysisRequest;
@@ -35,6 +38,8 @@ public function analyseExpr(
 	{
 		$exprResult = yield new ExprAnalysisRequest($stmt, $expr->expr, $scope, $context->enterDeep(), $alternativeNodeCallback);
 
+		$notEqualExprResult = yield ExprAnalysisRequest::createNoopRequest(new NotEqual($expr->expr, new Float_(0)), $scope);
+
 		return new ExprAnalysisResult(
 			$exprResult->type->toFloat(),
 			$exprResult->nativeType->toFloat(),
@@ -43,8 +48,8 @@ public function analyseExpr(
 			isAlwaysTerminating: false,
 			throwPoints: [],
 			impurePoints: [],
-			specifiedTruthyTypes: new SpecifiedTypes(),
-			specifiedFalseyTypes: new SpecifiedTypes(),
+			specifiedTruthyTypes: $notEqualExprResult->specifiedTruthyTypes->setRootExpr($expr),
+			specifiedFalseyTypes: $notEqualExprResult->specifiedFalseyTypes->setRootExpr($expr),
 			specifiedNullTypes: new SpecifiedTypes(),
 		);
 	}

src/Analyser/Generator/ExprHandler/CastIntHandler.php

@@ -4,7 +4,9 @@
 
 use Generator;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\BinaryOp\NotEqual;
 use PhpParser\Node\Expr\Cast\Int_;
+use PhpParser\Node\Scalar\Int_ as ScalarInt;
 use PhpParser\Node\Stmt;
 use PHPStan\Analyser\ExpressionContext;
 use PHPStan\Analyser\Generator\ExprAnalysisRequest;
@@ -36,6 +38,8 @@ public function analyseExpr(
 	{
 		$exprResult = yield new ExprAnalysisRequest($stmt, $expr->expr, $scope, $context->enterDeep(), $alternativeNodeCallback);
 
+		$notEqualExprResult = yield ExprAnalysisRequest::createNoopRequest(new NotEqual($expr->expr, new ScalarInt(0)), $scope);
+
 		return new ExprAnalysisResult(
 			$exprResult->type->toInteger(),
 			$exprResult->nativeType->toInteger(),
@@ -44,8 +48,8 @@ public function analyseExpr(
 			isAlwaysTerminating: false,
 			throwPoints: [],
 			impurePoints: [],
-			specifiedTruthyTypes: new SpecifiedTypes(),
-			specifiedFalseyTypes: new SpecifiedTypes(),
+			specifiedTruthyTypes: $notEqualExprResult->specifiedTruthyTypes->setRootExpr($expr),
+			specifiedFalseyTypes: $notEqualExprResult->specifiedFalseyTypes->setRootExpr($expr),
 			specifiedNullTypes: new SpecifiedTypes(),
 		);
 	}

src/Analyser/Generator/ExprHandler/CastStringHandler.php

@@ -4,6 +4,8 @@
 
 use Generator;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\BinaryOp\NotEqual;
+use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt;
 use PHPStan\Analyser\ExpressionContext;
 use PHPStan\Analyser\Generator\ExprAnalysisRequest;
@@ -35,6 +37,8 @@ public function analyseExpr(
 	{
 		$exprResult = yield new ExprAnalysisRequest($stmt, $expr->expr, $scope, $context->enterDeep(), $alternativeNodeCallback);
 
+		$notEqualExprResult = yield ExprAnalysisRequest::createNoopRequest(new NotEqual($expr->expr, new String_('')), $scope);
+
 		return new ExprAnalysisResult(
 			$exprResult->type->toString(),
 			$exprResult->nativeType->toString(),
@@ -43,8 +47,8 @@ public function analyseExpr(
 			isAlwaysTerminating: false,
 			throwPoints: [],
 			impurePoints: [],
-			specifiedTruthyTypes: new SpecifiedTypes(),
-			specifiedFalseyTypes: new SpecifiedTypes(),
+			specifiedTruthyTypes: $notEqualExprResult->specifiedTruthyTypes->setRootExpr($expr),
+			specifiedFalseyTypes: $notEqualExprResult->specifiedFalseyTypes->setRootExpr($expr),
 			specifiedNullTypes: new SpecifiedTypes(),
 		);
 	}

tests/PHPStan/Analyser/Generator/data/gnsr.php

@@ -597,3 +597,43 @@ function (bool $b): void {
 	assertType('false', !true);
 	assertType('bool', !$b);
 };
+
+function (mixed $m): void {
+	if ((bool) $m) {
+		assertType("mixed~(0|0.0|''|'0'|array{}|false|null)", $m);
+	} else {
+		assertType("0|0.0|''|'0'|array{}|false|null", $m);
+	}
+
+	assertType("mixed", $m);
+};
+
+function (mixed $m): void {
+	if ((string) $m) {
+		assertType("non-empty-array", $m);
+	} else {
+		assertType("non-empty-array", $m);
+	}
+
+	assertType("mixed", $m);
+};
+
+function (mixed $m): void {
+	if ((int) $m) {
+		assertType("non-empty-array", $m);
+	} else {
+		assertType("non-empty-array", $m);
+	}
+
+	assertType("mixed", $m);
+};
+
+function (mixed $m): void {
+	if ((float) $m) {
+		assertType("non-empty-array", $m);
+	} else {
+		assertType("non-empty-array", $m);
+	}
+
+	assertType("mixed", $m);
+};