Improve auth middleware logic

Author: williamdes

phpstan-baseline.neon

@@ -108,12 +108,6 @@ parameters:
 			count: 1
 			path: src/Controller/DevelopersController.php
 
-		-
-			message: '#^Method `redirect\(\)` must be used to prevent unreachable code\. Use `return \$this\-\>redirect\(\)` or assign it to a variable\.$#'
-			identifier: cake.controller.redirectMustBeUsed
-			count: 1
-			path: src/Controller/DevelopersController.php
-
 		-
 			message: '#^Parameter \#1 \$payload of method App\\Controller\\EventsController\:\:getHash\(\) expects string, string\|false given\.$#'
 			identifier: argument.type

src/Middleware/AuthenticationMiddleware.php

@@ -134,16 +134,19 @@ protected function isWriteAccessRequired(ServerRequest $request): bool
 
         // Check for the controller name
         if (! isset(self::READ_ONLY_ACCESS_CONTROL_LIST[$controllerName])) {
-            // Not public
-            return false;
+            return false;// The controller is not in the list
         }
 
         // Require for all actions ?
         if (self::READ_ONLY_ACCESS_CONTROL_LIST[$controllerName] === '*') {
-            return true;
+            return true;// Needs write access
         }
 
         // Check for the specific action name
-        return in_array($action, self::READ_ONLY_ACCESS_CONTROL_LIST[$controllerName]);
+        if (in_array($action, self::READ_ONLY_ACCESS_CONTROL_LIST[$controllerName])) {// phpcs:ignore SlevomatCodingStandard.ControlStructures.UselessIfConditionWithReturn.UselessIfCondition
+            return true;// Needs write access
+        }
+
+        return false;// phpcs:ignore SlevomatCodingStandard.ControlStructures.UselessIfConditionWithReturn.UselessIfCondition
     }
 }