Merge pull request #57 from php-http/spl_exceptions

Make custom SPL exception extensions final

Author: sagikazarmark

spec/Exception/BatchExceptionSpec.php

@@ -14,10 +14,14 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\BatchException');
     }
 
+    function it_is_a_runtime_exception()
+    {
+        $this->shouldHaveType('RuntimeException');
+    }
+
     function it_is_an_exception()
     {
         $this->shouldImplement('Http\Client\Exception');
-        $this->shouldHaveType('Exception');
     }
 
     function it_has_a_result()

spec/Exception/ClientExceptionSpec.php

@@ -20,7 +20,7 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\ClientException');
     }
 
-    function it_is_http_exception()
+    function it_is_an_http_exception()
     {
         $this->shouldHaveType('Http\Client\Exception\HttpException');
     }

spec/Exception/HttpExceptionSpec.php

@@ -20,7 +20,7 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\HttpException');
     }
 
-    function it_is_request_exception()
+    function it_is_a_request_exception()
     {
         $this->shouldHaveType('Http\Client\Exception\RequestException');
     }

spec/Exception/InvalidArgumentExceptionSpec.php

@@ -11,12 +11,12 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\InvalidArgumentException');
     }
 
-    function it_is_invalid_argument_exception()
+    function it_is_an_invalid_argument_exception()
     {
         $this->shouldHaveType('InvalidArgumentException');
     }
 
-    function it_is_exception()
+    function it_is_an_exception()
     {
         $this->shouldImplement('Http\Client\Exception');
     }

spec/Exception/NetworkExceptionSpec.php

@@ -17,7 +17,7 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\NetworkException');
     }
 
-    function it_is_request_exception()
+    function it_is_a_request_exception()
     {
         $this->shouldHaveType('Http\Client\Exception\RequestException');
     }

spec/Exception/RequestExceptionSpec.php

@@ -18,6 +18,11 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\RequestException');
     }
 
+    function it_is_a_transfer_exception()
+    {
+        $this->shouldHaveType('Http\Client\Exception\TransferException');
+    }
+
     function it_has_a_request(RequestInterface $request)
     {
         $this->getRequest()->shouldReturn($request);

spec/Exception/RuntimeExceptionSpec.php

@@ -11,12 +11,12 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\RuntimeException');
     }
 
-    function it_is_runtime_exception()
+    function it_is_a_runtime_exception()
     {
         $this->shouldHaveType('RuntimeException');
     }
 
-    function it_is_exception()
+    function it_is_an_exception()
     {
         $this->shouldImplement('Http\Client\Exception');
     }

spec/Exception/ServerExceptionSpec.php

@@ -20,7 +20,7 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\ServerException');
     }
 
-    function it_is_http_exception()
+    function it_is_an_http_exception()
     {
         $this->shouldHaveType('Http\Client\Exception\HttpException');
     }

spec/Exception/TransferExceptionSpec.php

@@ -11,4 +11,14 @@ function it_is_initializable()
     {
         $this->shouldHaveType('Http\Client\Exception\TransferException');
     }
+
+    function it_is_a_runtime_exception()
+    {
+        $this->shouldHaveType('RuntimeException');
+    }
+
+    function it_is_an_exception()
+    {
+        $this->shouldImplement('Http\Client\Exception');
+    }
 }

spec/Exception/UnexpectedValueExceptionSpec.php

@@ -11,12 +11,12 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Client\Exception\UnexpectedValueException');
     }
 
-    function it_is_invalid_argument_exception()
+    function it_is_an_unexpected_value_exception()
     {
         $this->shouldHaveType('UnexpectedValueException');
     }
 
-    function it_is_exception()
+    function it_is_an_exception()
     {
         $this->shouldImplement('Http\Client\Exception');
     }