Improve tests

Author: sagikazarmark

spec/BatchResultSpec.php

@@ -22,17 +22,23 @@ function it_is_immutable(RequestInterface $request, ResponseInterface $response)
         $new->getResponses()->shouldReturn([$response]);
     }
 
+    function it_has_a_responses(RequestInterface $request, ResponseInterface $response)
+    {
+        $new = $this->addResponse($request, $response);
+
+        $this->hasResponses()->shouldReturn(false);
+        $this->getResponses()->shouldReturn([]);
+        $new->hasResponses()->shouldReturn(true);
+        $new->getResponses()->shouldReturn([$response]);
+    }
+
     function it_has_a_response_for_a_request(RequestInterface $request, ResponseInterface $response)
     {
         $new = $this->addResponse($request, $response);
 
         $this->getResponseFor($request)->shouldReturn(null);
-        $this->hasResponses()->shouldReturn(false);
         $this->hasResponseFor($request)->shouldReturn(false);
-        $this->getResponses()->shouldReturn([]);
         $new->getResponseFor($request)->shouldReturn($response);
-        $new->hasResponses()->shouldReturn(true);
         $new->hasResponseFor($request)->shouldReturn(true);
-        $new->getResponses()->shouldReturn([$response]);
     }
 }

spec/Exception/BatchExceptionSpec.php

@@ -30,18 +30,32 @@ function it_has_a_result()
     function it_has_an_exception_for_a_request(RequestInterface $request, Exception $exception)
     {
         $this->getExceptionFor($request)->shouldReturn(null);
-        $this->hasExceptions()->shouldReturn(false);
         $this->hasExceptionFor($request)->shouldReturn(false);
-        $this->getExceptions()->shouldReturn([]);
-        $this->isSuccessful($request)->shouldReturn(false);
-        $this->isFailed($request)->shouldReturn(false);
 
         $this->addException($request, $exception);
 
         $this->getExceptionFor($request)->shouldReturn($exception);
-        $this->hasExceptions()->shouldReturn(true);
         $this->hasExceptionFor($request)->shouldReturn(true);
+    }
+
+    function it_has_exceptions(RequestInterface $request, Exception $exception)
+    {
+        $this->hasExceptions()->shouldReturn(false);
+        $this->getExceptions()->shouldReturn([]);
+
+        $this->addException($request, $exception);
+
+        $this->hasExceptions()->shouldReturn(true);
         $this->getExceptions()->shouldReturn([$exception]);
+    }
+
+    function it_checks_if_a_request_failed(RequestInterface $request, Exception $exception)
+    {
+        $this->isSuccessful($request)->shouldReturn(false);
+        $this->isFailed($request)->shouldReturn(false);
+
+        $this->addException($request, $exception);
+
         $this->isSuccessful($request)->shouldReturn(false);
         $this->isFailed($request)->shouldReturn(true);
     }