refactor!: require explicit creation of DHCPServer objects

Previously, anytime a DHCPServer object was constructed it would automatically initialize empty configurations for eligible interfaces. This caused some issues with some backend DHCPServer functions built into pfSense 2.8.0+. Now DHCPServers that don't already exist in the config must be created via POST request first. This will result in more consistent behavior.

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Endpoints/ServicesDHCPServerEndpoint.inc

@@ -15,7 +15,7 @@ class ServicesDHCPServerEndpoint extends Endpoint {
         # Set Endpoint attributes
         $this->url = '/api/v2/services/dhcp_server';
         $this->model_name = 'DHCPServer';
-        $this->request_method_options = ['GET', 'PATCH'];
+        $this->request_method_options = ['GET', 'POST', 'PATCH', 'DELETE'];
 
         # Construct the parent Endpoint object
         parent::__construct();

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/DHCPServer.inc

@@ -245,33 +245,9 @@ class DHCPServer extends Model {
             help_text: 'Static mappings applied to this DHCP server.',
         );
 
-        # Ensure all interfaces have DHCP server objects initialized
-        $this->init_interfaces();
-
         parent::__construct($id, $parent_id, $data, ...$options);
     }
 
-    /**
-     * Initializes configuration objects for defined interface that have not yet configured the DHCP server
-     */
-    private function init_interfaces(): void {
-        # Variables
-        $ifs_using_dhcp_server = array_keys($this->get_config(path: $this->config_path, default: []));
-
-        # Loop through each defined interface
-        foreach ($this->get_config('interfaces', []) as $if_id => $if) {
-            # Skip this interface if it is not a static interface or the subnet value is greater than or equal to 31
-            if (empty($if['ipaddr']) or !is_ipaddrv4($if['ipaddr']) or $if->subnet->value >= 31) {
-                continue;
-            }
-
-            # Otherwise, make this interface eligible for a DHCP server
-            if (!in_array($if_id, $ifs_using_dhcp_server)) {
-                $this->set_config(path: "$this->config_path/$if_id", value: ['range' => ['from' => '', 'to' => '']]);
-            }
-        }
-    }
-
     /**
      * Obtains the internal `interface` field value since it is not stored in the config.
      * @return string The internal interface ID of the DHCPServer.