Skip to content

Commit d78cd03

Browse files
committed
fix a11y in demo
1 parent a67f6a7 commit d78cd03

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

packages/react-core/src/components/Compass/examples/CompassDemo.tsx

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,29 @@ import OutlinedQuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/o
2424
export const CompassBasic: React.FunctionComponent = () => {
2525
const subTabs = (
2626
<Tabs activeKey={0} isSubtab onSelect={() => {}} aria-label="Compass navigation subtabs">
27-
<Tab eventKey={0} title={<TabTitleText>Subtab 1</TabTitleText>} />
28-
<Tab eventKey={1} title={<TabTitleText>Subtab 2</TabTitleText>} />
29-
<Tab eventKey={2} title={<TabTitleText>Disabled Subtab 3</TabTitleText>} isDisabled />
27+
<Tab
28+
tabContentId="subtab-1"
29+
eventKey={0}
30+
href="#"
31+
title={
32+
<TabTitleText>
33+
<div id="subtab-1">Subtab 1</div>
34+
</TabTitleText>
35+
}
36+
/>
37+
<Tab eventKey={1} href="#" title={<TabTitleText>Subtab 2</TabTitleText>} />
38+
<Tab eventKey={2} href="#" title={<TabTitleText>Disabled Subtab 3</TabTitleText>} isDisabled />
3039
</Tabs>
3140
);
3241

3342
const navContent = (
3443
<Tabs activeKey={0} onSelect={() => {}} component={TabsComponent.nav} aria-label="Compass navigation tabs">
35-
<Tab eventKey={0} title={<TabTitleText>Tab 1</TabTitleText>} aria-label="Compass tab with subtabs">
44+
<Tab eventKey={0} href="#" title={<TabTitleText>Tab 1</TabTitleText>} aria-label="Compass tab with subtabs">
3645
{subTabs}
3746
</Tab>
38-
<Tab eventKey={1} title={<TabTitleText>Tab 2</TabTitleText>} />
39-
<Tab eventKey={2} title={<TabTitleText>Tab 3</TabTitleText>} />
40-
<Tab eventKey={3} title={<TabTitleText>Disabled Tab 4</TabTitleText>} isDisabled />
47+
<Tab eventKey={1} href="#" title={<TabTitleText>Tab 2</TabTitleText>} />
48+
<Tab eventKey={2} href="#" title={<TabTitleText>Tab 3</TabTitleText>} />
49+
<Tab eventKey={3} href="#" title={<TabTitleText>Disabled Tab 4</TabTitleText>} isDisabled />
4150
</Tabs>
4251
);
4352

0 commit comments

Comments
 (0)