Skip to content

Commit d49cdd4

Browse files
authored
fix(MenuItemAction): update to use new favorite button props (#11998)
* fix(MenuItemAction): update to use new favorite button props * restore the favorite classes
1 parent 8cbb261 commit d49cdd4

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/react-core/src/components/Menu/MenuItemAction.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { forwardRef } from 'react';
22
import styles from '@patternfly/react-styles/css/components/Menu/menu';
33
import { css } from '@patternfly/react-styles';
4-
import StarIcon from '@patternfly/react-icons/dist/esm/icons/star-icon';
54
import { MenuContext, MenuItemContext } from './MenuContext';
65
import { Button } from '../Button';
76
export interface MenuItemActionProps extends React.HTMLProps<HTMLDivElement> {
@@ -60,9 +59,11 @@ const MenuItemActionBase: React.FunctionComponent<MenuItemActionProps> = ({
6059
ref={innerRef}
6160
role="menuitem"
6261
variant="plain"
62+
isFavorite={isFavorited !== null}
63+
isFavorited={isFavorited ?? false}
6364
tabIndex={-1}
6465
isDisabled={isDisabled || isDisabledContext}
65-
icon={icon === 'favorites' || isFavorited !== null ? <StarIcon /> : icon}
66+
icon={isFavorited === null ? icon : undefined}
6667
/>
6768
</div>
6869
);

0 commit comments

Comments
 (0)