Skip to content

Commit 7e33336

Browse files
chore(Modal): updated deprecated usage to promoted version (#11299)
1 parent e1c0596 commit 7e33336

File tree

4 files changed

+48
-44
lines changed

4 files changed

+48
-44
lines changed

packages/react-core/src/components/AboutModal/AboutModal.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { AboutModalBoxHeader } from './AboutModalBoxHeader';
66
import { AboutModalBoxBrand } from './AboutModalBoxBrand';
77
import { AboutModalBoxCloseButton } from './AboutModalBoxCloseButton';
88
import { AboutModalBox } from './AboutModalBox';
9-
import { Modal, ModalVariant } from '../../deprecated/components/Modal';
9+
import { Modal, ModalVariant } from '../Modal';
1010
import { GenerateId } from '../../helpers/GenerateId/GenerateId';
1111

1212
export interface AboutModalProps extends React.HTMLProps<HTMLDivElement> {
@@ -82,10 +82,8 @@ export const AboutModal: React.FunctionComponent<AboutModalProps> = ({
8282
{...(productName && { 'aria-labelledby': ariaLabelledBy })}
8383
aria-label={ariaLabel}
8484
onEscapePress={onClose}
85-
showClose={false}
8685
appendTo={appendTo}
8786
disableFocusTrap={disableFocusTrap}
88-
hasNoBodyWrapper
8987
>
9088
<AboutModalBox
9189
style={
Lines changed: 34 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
import React from 'react';
2-
import { DatePicker, Button, TimePicker, InputGroup, InputGroupItem } from '@patternfly/react-core';
3-
import { Modal as ModalDeprecated, ModalVariant as ModalVariantDeprecated } from '@patternfly/react-core/deprecated';
2+
import {
3+
DatePicker,
4+
Button,
5+
TimePicker,
6+
InputGroup,
7+
InputGroupItem,
8+
Modal,
9+
ModalVariant,
10+
ModalHeader,
11+
ModalBody,
12+
ModalFooter
13+
} from '@patternfly/react-core';
414

515
export const SimpleModal = () => {
616
const [isModalOpen, setIsModalOpen] = React.useState(false);
@@ -26,31 +36,37 @@ export const SimpleModal = () => {
2636
<Button variant="primary" onClick={handleModalToggle}>
2737
Launch modal
2838
</Button>
29-
<ModalDeprecated
39+
<Modal
3040
id="date-time-picker-modal"
31-
variant={ModalVariantDeprecated.small}
32-
title="Generic modal header"
41+
variant={ModalVariant.small}
3342
isOpen={isModalOpen}
3443
onEscapePress={onEscapePress}
3544
onClose={handleModalToggle}
36-
actions={[
45+
>
46+
<ModalHeader title="Generic modal header" />
47+
<ModalBody>
48+
<InputGroup>
49+
<InputGroupItem>
50+
<DatePicker ref={dateRef} appendTo={() => document.body} />
51+
</InputGroupItem>
52+
<InputGroupItem>
53+
<TimePicker
54+
menuAppendTo={() => document.body}
55+
isOpen={isTimePickerOpen}
56+
setIsOpen={setIsTimePickerOpen}
57+
/>
58+
</InputGroupItem>
59+
</InputGroup>
60+
</ModalBody>
61+
<ModalFooter>
3762
<Button key="confirm" variant="primary" onClick={handleModalToggle}>
3863
Confirm
39-
</Button>,
64+
</Button>
4065
<Button key="cancel" variant="link" onClick={handleModalToggle}>
4166
Cancel
4267
</Button>
43-
]}
44-
>
45-
<InputGroup>
46-
<InputGroupItem>
47-
<DatePicker ref={dateRef} appendTo={() => document.getElementById('date-time-picker-modal')} />
48-
</InputGroupItem>
49-
<InputGroupItem>
50-
<TimePicker menuAppendTo="parent" isOpen={isTimePickerOpen} setIsOpen={setIsTimePickerOpen} />
51-
</InputGroupItem>
52-
</InputGroup>
53-
</ModalDeprecated>
68+
</ModalFooter>
69+
</Modal>
5470
</React.Fragment>
5571
);
5672
};

packages/react-core/src/demos/examples/MultipleFileUpload/MultipleFileUploadRejectedFile.tsx

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@ import {
66
MultipleFileUploadStatus,
77
MultipleFileUploadStatusItem,
88
Checkbox,
9-
DropEvent
9+
DropEvent,
10+
Modal,
11+
ModalHeader,
12+
ModalBody
1013
} from '@patternfly/react-core';
11-
import { Modal as ModalDeprecated } from '@patternfly/react-core/deprecated';
1214
import UploadIcon from '@patternfly/react-icons/dist/esm/icons/upload-icon';
1315

1416
interface readFile {
@@ -135,16 +137,10 @@ export const MultipleFileUploadBasic: React.FunctionComponent = () => {
135137
))}
136138
</MultipleFileUploadStatus>
137139
)}
138-
<ModalDeprecated
139-
isOpen={!!modalText}
140-
title="Unsupported file"
141-
titleIconVariant="warning"
142-
showClose
143-
aria-label="unsupported file upload attempted"
144-
onClose={() => setModalText('')}
145-
>
146-
{modalText}
147-
</ModalDeprecated>
140+
<Modal isOpen={!!modalText} aria-label="unsupported file upload attempted" onClose={() => setModalText('')}>
141+
<ModalHeader title="Unsupported file" titleIconVariant="warning" />
142+
<ModalBody>{modalText}</ModalBody>
143+
</Modal>
148144
</MultipleFileUpload>
149145
<Checkbox
150146
id="horizontal-checkbox"

packages/react-integration/demo-app-ts/src/components/demos/WizardDemo/WizardDemo.tsx

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React from 'react';
2-
import { Button, Wizard, WizardHeader, WizardStep } from '@patternfly/react-core';
3-
import { Modal as ModalDeprecated } from '@patternfly/react-core/deprecated';
2+
import { Button, Wizard, WizardHeader, WizardStep, Modal } from '@patternfly/react-core';
43

54
import ExternalLinkAltIcon from '@patternfly/react-icons/dist/esm/icons/external-link-alt-icon';
65
import SlackHashIcon from '@patternfly/react-icons/dist/esm/icons/slack-hash-icon';
@@ -38,7 +37,7 @@ class WizardDemo extends React.Component<React.HTMLProps<HTMLDivElement>, Wizard
3837
<Button id="launchWiz" variant="primary" onClick={this.handleModalToggle}>
3938
Show Modal
4039
</Button>
41-
<ModalDeprecated isOpen={isOpen} showClose={false} hasNoBodyWrapper onEscapePress={this.handleModalToggle}>
40+
<Modal isOpen={isOpen} onEscapePress={this.handleModalToggle}>
4241
<Wizard
4342
id="modalWizId"
4443
width={710}
@@ -73,7 +72,7 @@ class WizardDemo extends React.Component<React.HTMLProps<HTMLDivElement>, Wizard
7372
<p>Step 5</p>
7473
</WizardStep>
7574
</Wizard>
76-
</ModalDeprecated>
75+
</Modal>
7776
<br />
7877
<br />
7978
<Wizard id="inPageWizId" height={500}>
@@ -263,12 +262,7 @@ class WizardDemo extends React.Component<React.HTMLProps<HTMLDivElement>, Wizard
263262
<Button id="launchWizOverflow" variant="primary" onClick={this.handleRoleWizardToggle}>
264263
Show Modal with Overflow
265264
</Button>
266-
<ModalDeprecated
267-
isOpen={isOpenWithRole}
268-
showClose={false}
269-
hasNoBodyWrapper
270-
onEscapePress={this.handleRoleWizardToggle}
271-
>
265+
<Modal isOpen={isOpenWithRole} onEscapePress={this.handleRoleWizardToggle}>
272266
<Wizard
273267
id="inModalWizWithOverflow"
274268
height={400}
@@ -478,7 +472,7 @@ class WizardDemo extends React.Component<React.HTMLProps<HTMLDivElement>, Wizard
478472
</div>
479473
</WizardStep>
480474
</Wizard>
481-
</ModalDeprecated>
475+
</Modal>
482476
</>
483477
);
484478
}

0 commit comments

Comments
 (0)