Skip to content

Commit a0d4540

Browse files
authored
update to use packaged/log (#26)
1 parent d533348 commit a0d4540

File tree

4 files changed

+15
-14
lines changed

4 files changed

+15
-14
lines changed

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
"ext-json": "*",
1616
"php": ">=7.1.0",
1717
"packaged/config": "^1.1",
18-
"packaged/helpers": "^1.0|^2.0"
18+
"packaged/helpers": "^1.0|^2.0",
19+
"packaged/log": "^1.1"
1920
},
2021
"suggest": {
2122
"php-amqplib/php-amqplib": "Enables using queues in RabbitMQ",

src/Provider/AbstractQueueProvider.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
use Packaged\Config\ConfigSectionInterface;
55
use Packaged\Config\ConfigurableInterface;
66
use Packaged\Config\Provider\ConfigSection;
7+
use Packaged\Log\Log;
78
use Packaged\Queue\IQueueProvider;
89

910
abstract class AbstractQueueProvider
@@ -56,7 +57,7 @@ protected function _construct()
5657
*/
5758
public static function create($queueName)
5859
{
59-
$object = new static;
60+
$object = new static();
6061
$object->_queueName = $queueName;
6162
return $object;
6263
}
@@ -102,6 +103,6 @@ protected function _processBatchMessage($msg)
102103

103104
protected function _log($message)
104105
{
105-
error_log('Queue (' . $this->_getQueueName() . '): ' . $message);
106+
Log::debug('Queue (' . $this->_getQueueName() . '): ' . $message);
106107
}
107108
}

src/Provider/Amqp/AmqpQueueProvider.php

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
use Exception;
55
use Packaged\Helpers\ValueAs;
6+
use Packaged\Log\Log;
67
use Packaged\Queue\IBatchQueueProvider;
78
use Packaged\Queue\Provider\AbstractQueueProvider;
89
use Packaged\Queue\Provider\QueueConnectionException;
@@ -155,7 +156,7 @@ public function pushBatch(array $batch, $persistent = null)
155156

156157
if($needDeclare)
157158
{
158-
$this->_log("Auto-declaring exchange and queue");
159+
Log::debug("Auto-declaring exchange and queue");
159160
$declareAttempts++;
160161
$this->declareExchange();
161162
$this->declareQueue();
@@ -226,10 +227,7 @@ public function push($data, $persistent = null)
226227
$duration = (microtime(true) - $startTime) * 1000;
227228
if($duration > $this->_slowPushThreshold)
228229
{
229-
error_log(
230-
'Slow push to queue ' . $this->_queueName . ' took '
231-
. round($duration, 1) . 'ms'
232-
);
230+
Log::warning('Slow push to queue. took ' . round($duration, 1) . 'ms');
233231
}
234232
}
235233
return $this;
@@ -579,7 +577,7 @@ protected function _getConnection($connectionMode)
579577
}
580578
catch(Exception $e)
581579
{
582-
$this->_log('AMQP host failed to connect [' . $e->getMessage() . '] (' . $host . ')');
580+
Log::error('AMQP host failed to connect [' . $e->getMessage() . '] (' . $host . ')');
583581
array_shift($this->_hosts);
584582
}
585583
$this->_persistentDefault = ValueAs::bool($config->getItem('persistent', false));
@@ -597,7 +595,7 @@ protected function _getConnection($connectionMode)
597595
}
598596
catch(AMQPRuntimeException $e)
599597
{
600-
$this->_log('Unable to start heartbeat sender. ' . $e->getMessage());
598+
Log::error('Unable to start heartbeat sender. ' . $e->getMessage());
601599
}
602600

603601
return $this->_connections[$connectionMode];
@@ -639,7 +637,7 @@ protected function _getChannel($connectionMode)
639637
}
640638
catch(Exception $e)
641639
{
642-
$this->_log(
640+
Log::error(
643641
'Error getting AMQP channel [' . $e->getMessage() . '] (' . $retries . ' retries remaining) '
644642
);
645643
$this->disconnect($connectionMode);

src/Provider/Google/GooglePubSubProvider.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
use Google\Cloud\PubSub\Subscription;
99
use Google\Cloud\PubSub\Topic;
1010
use Packaged\Helpers\ValueAs;
11+
use Packaged\Log\Log;
1112
use Packaged\Queue\IBatchQueueProvider;
1213
use Packaged\Queue\Provider\AbstractQueueProvider;
1314
use Packaged\Queue\Provider\QueueCredentialsException;
@@ -144,14 +145,14 @@ private function _createTopicAndSub()
144145
{
145146
try
146147
{
147-
$this->_log('Auto-creating subscription ' . $this->_getSubscription()->name());
148+
Log::debug('Auto-creating subscription ' . $this->_getSubscription()->name());
148149
$this->_getSubscription()->create($subscriptionOpts);
149150
}
150151
catch(NotFoundException $e)
151152
{
152153
try
153154
{
154-
$this->_log('Auto-creating topic ' . $this->_getTopic()->name());
155+
Log::debug('Auto-creating topic ' . $this->_getTopic()->name());
155156
$this->_getTopic()->create();
156157
}
157158
catch(ConflictException $e)
@@ -162,7 +163,7 @@ private function _createTopicAndSub()
162163
}
163164
}
164165

165-
$this->_log('Auto-creating subscription ' . $this->_getSubscription()->name() . " (second attempt)");
166+
Log::debug('Auto-creating subscription ' . $this->_getSubscription()->name() . " (second attempt)");
166167
$this->_getSubscription()->create($subscriptionOpts);
167168
}
168169
}

0 commit comments

Comments
 (0)