Fixed bug preventing a cursor from being reused after it was bound as a

REF CURSOR to a PL/SQL block that closes it.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -22,6 +22,8 @@ Thin Mode Changes
     (`issue 65 <https://github.com/oracle/python-oracledb/issues/65>`__).
 #)  Fixed bug when fetching nested cursors with more columns than the parent
     cursor.
+#)  Fixed bug preventing a cursor from being reused after it was bound as a
+    REF CURSOR to a PL/SQL block that closes it.
 
 Thick Mode Changes
 ++++++++++++++++++

src/oracledb/impl/thick/var.pyx

@@ -203,6 +203,7 @@ cdef class ThickVarImpl(BaseVarImpl):
                                    cursor_impl.prefetchrows) < 0:
             _raise_from_odpi()
         cursor_impl._fixup_ref_cursor = True
+        cursor.statement = None
 
     cdef int _set_num_elements_in_array(self, uint32_t num_elements) except -1:
         """

src/oracledb/impl/thin/messages.pyx

@@ -1022,6 +1022,7 @@ cdef class MessageWithData(Message):
             else:
                 buf.write_ub4(1)
                 buf.write_ub4(cursor_impl._statement._cursor_id)
+            value.statement = None
         elif ora_type_num == TNS_DATA_TYPE_BOOLEAN:
             buf.write_bool(value)
         elif ora_type_num == TNS_DATA_TYPE_INTERVAL_DS:

tests/sql/create_schema.sql

@@ -876,6 +876,10 @@ create or replace package &main_user..pkg_TestRefCursors as
         a_Cursor                        out sys_refcursor
     );
 
+    procedure TestCloseCursor (
+        a_Cursor                        sys_refcursor
+    );
+
 end;
 /
 
@@ -929,6 +933,22 @@ create or replace package body &main_user..pkg_TestRefCursors as
             from dual;
     end;
 
+    procedure TestCloseCursor (
+        a_Cursor                        sys_refcursor
+    ) is
+        t_Id                            number;
+        t_StrVal                        varchar2(400);
+    begin
+        delete from TestTempTable;
+        fetch a_Cursor into t_Id, t_StrVal;
+        if not a_Cursor%notfound then
+            insert into TestTempTable (IntCol, StringCol1)
+            values (t_Id, t_StrVal);
+	end if;
+        close a_Cursor;
+        commit;
+    end;
+
 end;
 /
 

tests/test_1300_cursor_var.py

@@ -301,5 +301,28 @@ def test_1313_fetch_nested_cursors_with_more_cols_than_parent(self):
         ]
         self.assertEqual(rows, expected_value)
 
+    def test_1314_reuse_closed_ref_cursor_with_different_sql(self):
+        "1314 - test reusing a closed ref cursor for executing different sql"
+        sql = "select 13141, 'String 13141' from dual"
+        ref_cursor = self.connection.cursor()
+        ref_cursor.prefetchrows = 0
+        ref_cursor.execute(sql)
+        plsql = "begin pkg_TestRefCursors.TestCloseCursor(:rcursor); end;"
+        self.cursor.execute(plsql, rcursor=ref_cursor)
+        sql = "select 13142, 'String 13142' from dual"
+        ref_cursor.execute(sql)
+        self.assertEqual(ref_cursor.fetchall(), [(13142, 'String 13142'),])
+
+    def test_1315_reuse_closed_ref_cursor_with_same_sql(self):
+        "1315 - test reusing a closed ref cursor for executing same sql"
+        sql = "select 1315, 'String 1315' from dual"
+        ref_cursor = self.connection.cursor()
+        ref_cursor.prefetchrows = 0
+        ref_cursor.execute(sql)
+        plsql = "begin pkg_TestRefCursors.TestCloseCursor(:rcursor); end;"
+        self.cursor.execute(plsql, rcursor=ref_cursor)
+        ref_cursor.execute(sql)
+        self.assertEqual(ref_cursor.fetchall(), [(1315, 'String 1315'),])
+
 if __name__ == "__main__":
     test_env.run_test_cases()