Attribute "getmode" on the ConnectionPool object is now one of the

values of the enumeration in order to be consistent with the other uses
of this attribute.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -32,6 +32,9 @@ Thick Mode Changes
 Common Changes
 ++++++++++++++
 
+#)  Attribute :data:`ConnectionPool.getmode` is now one of the values of the
+    enumeration :ref:`connection pool get modes <connpoolmodes>` in order to be
+    consistent with the other uses of this attribute.
 #)  Error ``DPY-3027: binding a cursor from a different connection is not
     supported`` is now raised when attempting to bind a cursor created on a
     different connection. Previously, the attempt may have succeeded or may

src/oracledb/pool.py

@@ -125,12 +125,12 @@ def dsn(self) -> str:
         return self._impl.dsn
 
     @property
-    def getmode(self) -> int:
+    def getmode(self) -> oracledb.PoolGetMode:
         self._verify_open()
-        return self._impl.get_getmode()
+        return oracledb.PoolGetMode(self._impl.get_getmode())
 
     @getmode.setter
-    def getmode(self, value: int) -> None:
+    def getmode(self, value: oracledb.PoolGetMode) -> None:
         self._verify_open()
         self._impl.set_getmode(value)
 

tests/test_2400_pool.py

@@ -164,6 +164,7 @@ def test_2400(self):
         self.assertEqual(pool.tnsentry, pool.dsn)
         if test_env.get_client_version() >= (12, 2):
             self.assertEqual(pool.getmode, oracledb.POOL_GETMODE_WAIT)
+            self.assertIs(pool.getmode, oracledb.PoolGetMode.WAIT)
         self.assertTrue(pool.homogeneous)
         self.assertEqual(pool.increment, 1)
         self.assertEqual(pool.max, 2)

utils/templates/pool.py

@@ -123,12 +123,12 @@ def dsn(self) -> str:
         return self._impl.dsn
 
     @property
-    def getmode(self) -> int:
+    def getmode(self) -> oracledb.PoolGetMode:
         self._verify_open()
-        return self._impl.get_getmode()
+        return oracledb.PoolGetMode(self._impl.get_getmode())
 
     @getmode.setter
-    def getmode(self, value: int) -> None:
+    def getmode(self, value: oracledb.PoolGetMode) -> None:
         self._verify_open()
         self._impl.set_getmode(value)