Fixed bug in return value of SodaOperation.replaceOne().

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -36,6 +36,8 @@ Thin Mode Changes
 Thick Mode Changes
 ++++++++++++++++++
 
+#)  Fixed bug in return value of :meth:`SodaOperation.replaceOne()`.
+
 Common Changes
 ++++++++++++++
 

src/oracledb/impl/thick/soda.pyx

@@ -432,6 +432,7 @@ cdef class ThickSodaCollImpl(BaseSodaCollImpl):
             _raise_from_odpi()
         if return_doc:
             return output_doc_impl
+        return replaced
 
     def save(self, ThickSodaDocImpl doc_impl, str hint, bint return_doc):
         """

tests/test_3400_soda_collection.py

@@ -117,7 +117,8 @@ def test_3403_replace_document(self):
         content = {"name": "John", "address": {"city": "Sydney"}}
         doc = coll.insertOneAndGet(content)
         new_content = {"name": "John", "address": {"city": "Melbourne"}}
-        coll.find().key(doc.key).replaceOne(new_content)
+        replaced = coll.find().key(doc.key).replaceOne(new_content)
+        self.assertTrue(replaced)
         self.conn.commit()
         doc = coll.find().key(doc.key).getOne().getContent()
         self.__normalize_docs([doc])