Merge pull request #817 from opsmill/develop

Merge develop into infrahub-develop

Author: ogenstad

.github/pull_request_template.md

@@ -0,0 +1,72 @@
+<!--
+This template is a guide, not a gate. Use as much or as little as helps the
+reviewer understand your change. For straightforward PRs (dependency bumps,
+linting fixes, CI tweaks, typos) a one-liner description is perfectly fine
+-- delete the sections that don't add value.
+
+Rule of thumb: the more the change affects behavior, the more sections you
+should fill in.
+-->
+
+# Why
+
+<!-- Problem statement: what's broken/slow/confusing/missing today? (1-3 sentences) -->
+
+<!-- Goal: what outcome does this PR achieve? -->
+
+<!-- Non-goals: what this PR intentionally does NOT do (prevents scope creep) -->
+
+Closes <!-- #issue -->
+
+## What changed
+
+<!-- Group changes by intent, not by file. -->
+
+<!-- Behavioral changes: what users/systems will observe differently -->
+-
+
+<!-- Implementation notes: key design choices, tradeoffs, notable refactors -->
+
+<!-- What stayed the same: especially useful if you touched sensitive areas -->
+<!-- e.g., "No schema changes", "API contract unchanged", "Only affects branch X" -->
+
+<!-- If the diff is large, add a suggested review order:
+### Suggested review order
+1. Start with ...
+2. Then ...
+3. Tests are ...
+-->
+
+## How to review
+
+<!-- Key files/areas to focus on vs. mechanical/generated changes -->
+
+<!-- Risky or uncertain parts where you want extra scrutiny -->
+
+<!-- Alternatives considered (only if it affects future direction) -->
+
+## How to test
+
+<!-- Make it runnable and specific -->
+
+```bash
+# Commands to validate
+```
+
+<!-- Expected outputs, screenshots, or links to CI results -->
+
+## Impact & rollout
+
+<!-- Delete items that don't apply -->
+
+- **Backward compatibility:** <!-- any breaking changes or migration steps -->
+- **Performance:** <!-- implications, measurements if relevant -->
+- **Config/env changes:** <!-- new settings, feature flags, env vars -->
+- **Deployment notes:** <!-- "safe to deploy" vs "requires coordinated release" -->
+
+## Checklist
+
+- [ ] Tests added/updated
+- [ ] Changelog entry added (`uv run towncrier create ...`)
+- [ ] External docs updated (if user-facing or ops-facing change)
+- [ ] Internal .md docs updated (internal knowledge and AI code tools knowledge)

AGENTS.md

@@ -7,16 +7,17 @@ Infrahub Python SDK - async/sync client for Infrahub infrastructure management.
 ```bash
 uv sync --all-groups --all-extras   # Install all deps
 uv run invoke format                # Format code
-uv run invoke lint                  # Lint (ruff + mypy + yamllint)
+uv run invoke lint                  # All linters (code + yamllint + documentation)
+uv run invoke lint-code             # All linters for Python code
 uv run pytest tests/unit/           # Unit tests
 uv run pytest tests/integration/    # Integration tests
 ```
 
-## Tech Stack
+## Tech stack
 
 Python 3.10-3.13, UV, pydantic >=2.0, httpx, graphql-core
 
-## Code Pattern
+## Code pattern
 
 ```python
 # Always provide both async and sync versions
@@ -27,7 +28,7 @@ node = await client.get(kind="NetworkDevice")
 await node.save()
 ```
 
-## Project Structure
+## Project structure
 
 ```text
 infrahub_sdk/
@@ -38,7 +39,7 @@ infrahub_sdk/
 └── pytest_plugin/      # Custom pytest plugin
 ```
 
-## Markdown Style
+## Markdown style
 
 When editing `.md` or `.mdx` files, run `uv run invoke lint-docs` before committing.
 
@@ -52,7 +53,7 @@ Key rules:
 
 ✅ **Always**
 
-- Run `uv run invoke format lint` before committing Python code
+- Run `uv run invoke format lint-code` before committing Python code
 - Run markdownlint before committing markdown changes
 - Follow async/sync dual pattern for new features
 - Use type hints on all function signatures
@@ -69,7 +70,7 @@ Key rules:
 - Modify generated code (protocols.py)
 - Bypass type checking without justification
 
-## Subdirectory Guides
+## Subdirectory guides
 
 - [docs/AGENTS.md](docs/AGENTS.md) - Documentation (Docusaurus)
 - [infrahub_sdk/ctl/AGENTS.md](infrahub_sdk/ctl/AGENTS.md) - CLI development

tasks.py

@@ -218,6 +218,14 @@ def lint_vale(context: Context) -> None:
         context.run(exec_cmd)
 
 
+@task
+def lint_code(context: Context) -> None:
+    """Run all code linters."""
+    lint_ruff(context)
+    lint_ty(context)
+    lint_mypy(context)
+
+
 @task
 def lint_docs(context: Context) -> None:
     """Run all documentation linters."""
@@ -229,9 +237,7 @@ def lint_docs(context: Context) -> None:
 def lint_all(context: Context) -> None:
     """Run all linters."""
     lint_yaml(context)
-    lint_ruff(context)
-    lint_ty(context)
-    lint_mypy(context)
+    lint_code(context)
     lint_docs(context)