Skip to content

Commit 11f0eaa

Browse files
authored
Rubicon: pass imp[].ext.tid (prebid#3648)
1 parent 19d25f3 commit 11f0eaa

File tree

7 files changed

+17
-7
lines changed

7 files changed

+17
-7
lines changed

src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ public class RubiconBidder implements Bidder<BidRequest> {
154154
private static final String FPD_KEYWORDS_FIELD = "keywords";
155155
private static final String DFP_ADUNIT_CODE_FIELD = "dfp_ad_unit_code";
156156
private static final String STYPE_FIELD = "stype";
157+
private static final String TID_FIELD = "tid";
157158
private static final String PREBID_EXT = "prebid";
158159
private static final String PBS_LOGIN = "pbs_login";
159160
private static final String PBS_VERSION = "pbs_version";
@@ -700,6 +701,7 @@ private RubiconImpExt makeImpExt(Imp imp,
700701
.maxbids(getMaxBids(extRequest))
701702
.gpid(getGpid(imp.getExt()))
702703
.skadn(getSkadn(imp.getExt()))
704+
.tid(getTid(imp.getExt()))
703705
.prebid(rubiconImpExtPrebid)
704706
.build();
705707
}
@@ -947,6 +949,11 @@ private ObjectNode getSkadn(ObjectNode impExt) {
947949
return skadnNode != null && skadnNode.isObject() ? (ObjectNode) skadnNode : null;
948950
}
949951

952+
private String getTid(ObjectNode impExt) {
953+
final JsonNode tidNode = impExt.get(TID_FIELD);
954+
return tidNode != null && tidNode.isTextual() ? tidNode.asText() : null;
955+
}
956+
950957
private String getAdSlot(Imp imp) {
951958
final ObjectNode dataNode = toObjectNode(imp.getExt().get(FPD_DATA_FIELD));
952959

src/main/java/org/prebid/server/bidder/rubicon/proto/request/RubiconImpExt.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,7 @@ public class RubiconImpExt {
2020

2121
ObjectNode skadn;
2222

23+
String tid;
24+
2325
RubiconImpExtPrebid prebid;
2426
}

src/test/java/org/prebid/server/it/OwnAdxTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
import io.restassured.response.Response;
44
import org.json.JSONException;
55
import org.junit.jupiter.api.Test;
6-
import org.junit.runner.RunWith;
76
import org.prebid.server.model.Endpoint;
8-
import org.springframework.test.context.junit4.SpringRunner;
97

108
import java.io.IOException;
119

@@ -16,7 +14,6 @@
1614
import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo;
1715
import static java.util.Collections.singletonList;
1816

19-
@RunWith(SpringRunner.class)
2017
public class OwnAdxTest extends IntegrationTest {
2118

2219
@Test

src/test/resources/org/prebid/server/it/hooks/reject/test-rubicon-bid-request-1.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
"mint_version": ""
3838
}
3939
},
40-
"maxbids": 1
40+
"maxbids": 1,
41+
"tid": "${json-unit.any-string}"
4142
}
4243
}
4344
],

src/test/resources/org/prebid/server/it/hooks/sample-module/test-rubicon-bid-request-1.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
"mint_version": ""
3939
}
4040
},
41-
"maxbids": 1
41+
"maxbids": 1,
42+
"tid": "${json-unit.any-string}"
4243
}
4344
}
4445
],

src/test/resources/org/prebid/server/it/openrtb2/magnite/test-magnite-bid-request.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
"mint_version": ""
2828
}
2929
},
30-
"maxbids": 1
30+
"maxbids": 1,
31+
"tid": "${json-unit.any-string}"
3132
}
3233
}
3334
],

src/test/resources/org/prebid/server/it/openrtb2/rubicon/test-rubicon-bid-request.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
"mint_version": ""
2828
}
2929
},
30-
"maxbids": 1
30+
"maxbids": 1,
31+
"tid": "${json-unit.any-string}"
3132
}
3233
}
3334
],

0 commit comments

Comments
 (0)