feat(identity): Add id field in update domain tool(#31)

- Add id field in update_domain tool
- Tests are updated and passing

Author: S0okJu

src/openstack_mcp_server/tools/identity_tools.py

@@ -163,11 +163,12 @@ def delete_domain(self, name: str) -> None:
 
         return None
 
-    def update_domain(self, name: str, description: str | None = None, is_enabled: bool | None = None) -> Domain:
+    def update_domain(self, id: str, name: str | None = None, description: str | None = None, is_enabled: bool | None = None) -> Domain:
         """
         Update a domain.
 
-        :param name: The name of the domain. (required)
+        :param id: The ID of the domain. (required)
+        :param name: The name of the domain. (optional)
         :param description: The description of the domain. (optional)
         :param is_enabled: Whether the domain is enabled. (optional)
         """
@@ -181,8 +182,7 @@ def update_domain(self, name: str, description: str | None = None, is_enabled: b
         if is_enabled is not None:
             args["is_enabled"] = is_enabled
 
-        domain = conn.identity.find_domain(name_or_id=name)
-        updated_domain = conn.identity.update_domain(domain=domain, **args)
+        updated_domain = conn.identity.update_domain(domain=id, **args)
 
         return Domain(id=updated_domain.id, name=updated_domain.name, description=updated_domain.description, is_enabled=updated_domain.is_enabled)
 

tests/tools/test_identity_tools.py

@@ -555,20 +555,18 @@ def test_update_domain_with_all_fields_success(self, mock_get_openstack_conn_ide
         mock_domain.description = "domainone description"
         mock_domain.is_enabled = True
 
-        # Configure mock domain.find_domain() and update_domain()
-        mock_conn.identity.find_domain.return_value = mock_domain
+        # Configure mock domain.update_domain()
         mock_conn.identity.update_domain.return_value = mock_domain
 
         # Test update_domain()
         identity_tools = self.get_identity_tools()
-        result = identity_tools.update_domain(name="domainone", description="domainone description", is_enabled=True)
+        result = identity_tools.update_domain(id="d01a81393377480cbd75c0210442e687", name="domainone", description="domainone description", is_enabled=True)
 
         # Verify results
         assert result == Domain(id="d01a81393377480cbd75c0210442e687", name="domainone", description="domainone description", is_enabled=True)
 
         # Verify mock calls
-        mock_conn.identity.find_domain.assert_called_once_with(name_or_id="domainone")
-        mock_conn.identity.update_domain.assert_called_once_with(domain=mock_domain, name="domainone", description="domainone description", is_enabled=True)
+        mock_conn.identity.update_domain.assert_called_once_with(domain="d01a81393377480cbd75c0210442e687", name="domainone", description="domainone description", is_enabled=True)
 
 
     def test_update_domain_with_empty_args(self, mock_get_openstack_conn_identity):
@@ -582,26 +580,24 @@ def test_update_domain_with_empty_args(self, mock_get_openstack_conn_identity):
         mock_domain.description = "domainone description"
         mock_domain.is_enabled = True
 
-        # Configure mock domain.find_domain() and update_domain()
-        mock_conn.identity.find_domain.return_value = mock_domain
+        # Configure mock domain.update_domain()
         mock_conn.identity.update_domain.return_value = mock_domain
 
         # Test update_domain()
         identity_tools = self.get_identity_tools()
-        result = identity_tools.update_domain(name="domainone")
+        result = identity_tools.update_domain(id="d01a81393377480cbd75c0210442e687")
 
         # Verify results
         assert result == Domain(id="d01a81393377480cbd75c0210442e687", name="domainone", description="domainone description", is_enabled=True)
 
         # Verify mock calls
-        mock_conn.identity.find_domain.assert_called_once_with(name_or_id="domainone")
-        mock_conn.identity.update_domain.assert_called_once_with(domain=mock_domain, name="domainone")
+        mock_conn.identity.update_domain.assert_called_once_with(domain="d01a81393377480cbd75c0210442e687")
 
-    def test_update_domain_with_empty_name(self, mock_get_openstack_conn_identity):
+    def test_update_domain_with_empty_id(self, mock_get_openstack_conn_identity):
         """Test updating a identity domain with an empty name."""
         mock_conn = mock_get_openstack_conn_identity
 
-        mock_conn.identity.find_domain.side_effect = exceptions.BadRequestException(
+        mock_conn.identity.update_domain.side_effect = exceptions.BadRequestException(
             "Field required",
         )
 
@@ -610,9 +606,9 @@ def test_update_domain_with_empty_name(self, mock_get_openstack_conn_identity):
 
         # Verify exception is raised
         with pytest.raises(exceptions.BadRequestException, match="Field required"):
-            identity_tools.update_domain(name="")
+            identity_tools.update_domain(id="")
 
         # Verify mock calls
-        mock_conn.identity.find_domain.assert_called_once_with(name_or_id="")
+        mock_conn.identity.update_domain.assert_called_once_with(domain="")