From 33ecf6e861babaf23fb61b24bde8a11171e36887 Mon Sep 17 00:00:00 2001 From: Francesco Pantano Date: Sun, 6 Apr 2025 15:34:57 +0200 Subject: [PATCH] Fix ListsMustHaveSSATags raised by crd-schema-checker In openstack-operator, where we bump all the sub components CRDs, we currently get an error thrown by crd-schema-checker: ``` > ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts must set x-kubernetes-list-type > ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.keystone.template.extraMounts[*].extraVol must set x-kubernetes-list-type ... ``` This patch adds the `listType` to storage module extraMounts to make the check happy [1]. [1] https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/555-server-side-apply/README.md#lists Signed-off-by: Francesco Pantano --- modules/storage/storage.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/storage/storage.go b/modules/storage/storage.go index ff654d05..17a0e4f5 100644 --- a/modules/storage/storage.go +++ b/modules/storage/storage.go @@ -108,13 +108,16 @@ type Volume struct { type VolMounts struct { // +kubebuilder:validation:type={PropagationEverywhere} // Propagation defines which pod should mount the volume + // +listType=atomic Propagation []PropagationType `json:"propagation,omitempty"` // Label associated to a given extraMount // +kubebuilder:validation:Optional ExtraVolType ExtraVolType `json:"extraVolType,omitempty"` // +kubebuilder:validation:Required + // +listType=atomic Volumes []Volume `json:"volumes"` // +kubebuilder:validation:Required + // +listType=atomic Mounts []corev1.VolumeMount `json:"mounts"` }