Skip to content

ci(ai-helpers): increase resource requests and add memory limit#79987

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cblecker:ci/ai-helpers-resource-limits
Jun 2, 2026
Merged

ci(ai-helpers): increase resource requests and add memory limit#79987
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cblecker:ci/ai-helpers-resource-limits

Conversation

@cblecker

@cblecker cblecker commented Jun 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Increase CPU requests from 100m to 1 core
  • Increase memory requests from 200Mi to 2Gi
  • Add memory limit of 2Gi (matching requests, consistent with openshift-online/gcp-hcp-infra pattern)

Test plan

  • Verify CI config validates (make checkconfig)
  • Confirm updated resources are reflected in generated Prow job configs after merge

Summary by CodeRabbit

This PR updates the CI resource configuration for the openshift-eng/ai-helpers repository's main branch builds. The change modifies the resource allocation for all job runners (denoted by the '*' wildcard in the resources block):

Changes made:

  • Increases CPU requests from 100m (0.1 core) to 1 (1 full core)
  • Increases memory requests from 200Mi to 2Gi
  • Adds an explicit memory limit of 2Gi (matching the requests, following the established pattern used in openshift-online/gcp-hcp-infra)

The modification is minimal (4 lines added, 2 lines removed) and targets a single configuration file: ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml. This ensures the AI helpers CI jobs have sufficient resources to execute reliably while maintaining consistent resource management practices across the release infrastructure.

Set CPU requests to 1 core and memory requests/limits to 2Gi.

Assisted-by: Claude:claude-opus-4-6[1m]
@openshift-ci openshift-ci Bot requested review from bentito and enxebre June 2, 2026 15:29
@stbenjam

stbenjam commented Jun 2, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2026
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Single CI configuration update that changes resource allocation for the wildcard job runner from minimal requests (100m CPU, 200Mi memory) to higher explicit limits and requests (2Gi memory, 1 CPU request).

Changes

CI Resource Configuration Update

Layer / File(s) Summary
Wildcard job runner resource limits and requests
ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml
The resources: '*' block is updated to replace prior CPU/memory request values with explicit limits and requests sections, increasing memory allocation to 2Gi and setting CPU requests to "1".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#79729: Both PRs modify the CI wildcard (resources['*']/'*') runner resource settings (memory/cpu requests/limits) in OpenShift CI YAML configuration.
  • openshift/release#79771: Both PRs modify the CI wildcard (resources: '*') CPU/memory configuration by changing between requests and limits in OpenShift CI job manifests.
  • openshift/release#79755: Both PRs adjust CI job resources for the wildcard (*) runner by changing requests/limits memory values in their respective CI YAML configs.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • dgoodwin
  • deepsm007
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly summarizes the main change: increasing resource requests and adding a memory limit to CI/CD configuration for ai-helpers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not contain any Ginkgo test definitions or modifications. Changes are limited to CI/CD resource configuration (CPU/memory limits) in a YAML file. Custom check is not applicable.
Test Structure And Quality ✅ Passed Check is not applicable: the PR modifies only a YAML CI/CD configuration file, not Ginkgo test code. The custom check requires review of Ginkgo test structure but no test files are present in this PR.
Microshift Test Compatibility ✅ Passed PR modifies only CI/CD resource configuration (YAML). No new Ginkgo e2e tests are added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only CI/CD configuration (resource limits in YAML) with no new Ginkgo e2e test code; SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Change only adjusts resource requests/limits for CI jobs; no scheduling constraints (affinity, nodeSelectors, topology spreads) that would break on SNO/Two-Node/HyperShift topologies.
Ote Binary Stdout Contract ✅ Passed PR only modifies CI configuration YAML (resource limits/requests); contains no OTE binary, test code, or stdout-writing process-level code that the check is designed to flag.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only changes CI configuration (resource limits/requests in YAML), not new Ginkgo e2e tests, so IPv6/disconnected network compatibility check does not apply.
No-Weak-Crypto ✅ Passed This PR modifies only a CI/CD YAML configuration file with no cryptographic code, weak algorithms, custom crypto implementations, or improper secret comparisons.
Container-Privileges ✅ Passed PR only modifies resource requests/limits in ci-operator config file; no privileged containers, hostPID, hostNetwork, hostIPC, SYS_ADMIN capabilities, or allowPrivilegeEscalation settings added.
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies only resource limits/requests and environment variable configs. No passwords, tokens, API keys, PII, session IDs, hostnames, or customer data are exposed in logs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@cblecker: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis openshift-eng/ai-helpers presubmit Ci-operator config changed
pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis-minimal openshift-eng/ai-helpers presubmit Ci-operator config changed
pull-ci-openshift-eng-ai-helpers-main-images openshift-eng/ai-helpers presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2026
@cblecker

cblecker commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml`:
- Around line 15-21: The ci-operator resource change (resources.requests.cpu:
"1" and resources.limits/requests.memory: 2Gi) wasn't propagated into the
generated Prow job specs (presubmits/postsubmits); regenerate the job outputs
with the repo's generator (run the project's update target, e.g., make update or
the repository's canonical job-gen command), commit the updated generated
presubmit/postsubmit YAMLs, and verify the resulting generated job specs include
requests.cpu: "1" and memory: 2Gi (and match the resources block from the source
ci-operator config).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4bc4526e-04fc-4e73-b760-a792e4c76229

📥 Commits

Reviewing files that changed from the base of the PR and between 558ee46 and d54089e.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml

@cblecker

cblecker commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 2, 2026
@openshift-ci

openshift-ci Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@cblecker: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-eng/ai-helpers/main/eval-payload-analysis d54089e link unknown /pj-rehearse pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis
ci/rehearse/openshift-eng/ai-helpers/main/eval-payload-analysis-minimal d54089e link unknown /pj-rehearse pull-ci-openshift-eng-ai-helpers-main-eval-payload-analysis-minimal

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit d3e7de4 into openshift:main Jun 2, 2026
15 of 17 checks passed
@cblecker cblecker deleted the ci/ai-helpers-resource-limits branch June 2, 2026 16:21
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jun 4, 2026
…shift#79987)

Set CPU requests to 1 core and memory requests/limits to 2Gi.

Assisted-by: Claude:claude-opus-4-6[1m]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants