ci(ai-helpers): increase resource requests and add memory limit#79987
Conversation
Set CPU requests to 1 core and memory requests/limits to 2Gi. Assisted-by: Claude:claude-opus-4-6[1m]
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughSingle CI configuration update that changes resource allocation for the wildcard job runner from minimal requests (100m CPU, 200Mi memory) to higher explicit limits and requests (2Gi memory, 1 CPU request). ChangesCI Resource Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse auto-ack |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml`:
- Around line 15-21: The ci-operator resource change (resources.requests.cpu:
"1" and resources.limits/requests.memory: 2Gi) wasn't propagated into the
generated Prow job specs (presubmits/postsubmits); regenerate the job outputs
with the repo's generator (run the project's update target, e.g., make update or
the repository's canonical job-gen command), commit the updated generated
presubmit/postsubmit YAMLs, and verify the resulting generated job specs include
requests.cpu: "1" and memory: 2Gi (and match the resources block from the source
ci-operator config).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4bc4526e-04fc-4e73-b760-a792e4c76229
📒 Files selected for processing (1)
ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml
|
/pj-rehearse ack |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@cblecker: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
d3e7de4
into
openshift:main
…shift#79987) Set CPU requests to 1 core and memory requests/limits to 2Gi. Assisted-by: Claude:claude-opus-4-6[1m]
Summary
100mto1core200Mito2Gi2Gi(matching requests, consistent withopenshift-online/gcp-hcp-infrapattern)Test plan
make checkconfig)Summary by CodeRabbit
This PR updates the CI resource configuration for the
openshift-eng/ai-helpersrepository's main branch builds. The change modifies the resource allocation for all job runners (denoted by the'*'wildcard in the resources block):Changes made:
100m(0.1 core) to1(1 full core)200Mito2Gi2Gi(matching the requests, following the established pattern used in openshift-online/gcp-hcp-infra)The modification is minimal (4 lines added, 2 lines removed) and targets a single configuration file:
ci-operator/config/openshift-eng/ai-helpers/openshift-eng-ai-helpers-main.yaml. This ensures the AI helpers CI jobs have sufficient resources to execute reliably while maintaining consistent resource management practices across the release infrastructure.