From d0e892526a9639370fd853e41303e4e86c301c5d Mon Sep 17 00:00:00 2001 From: vprashar2929 Date: Mon, 16 Feb 2026 11:28:57 +0530 Subject: [PATCH] refactor: simplify redundant error checking conditions This commit simplifies the error checking conditions in the * lib/resourcebuilder/apps.go * pkg/cvo/upgradeable.go Signed-off-by: vprashar2929 --- lib/resourcebuilder/apps.go | 2 +- pkg/cvo/upgradeable.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/resourcebuilder/apps.go b/lib/resourcebuilder/apps.go index 6d05f41a1..af1e252ab 100644 --- a/lib/resourcebuilder/apps.go +++ b/lib/resourcebuilder/apps.go @@ -46,7 +46,7 @@ func (b *builder) modifyDeployment(ctx context.Context, deployment *appsv1.Deplo if err != nil && !errors.IsNotFound(err) { return err } - if !errors.IsNotFound(err) { + if err == nil { lbURL, err := url.Parse(infrastructureConfig.Status.APIServerInternalURL) if err != nil { return err diff --git a/pkg/cvo/upgradeable.go b/pkg/cvo/upgradeable.go index 1d60a5f54..9a119e6c9 100644 --- a/pkg/cvo/upgradeable.go +++ b/pkg/cvo/upgradeable.go @@ -378,7 +378,7 @@ func (check *clusterAdminAcksCompletedUpgradeable) Check() *configv1.ClusterOper var message string if apierrors.IsNotFound(err) { message = fmt.Sprintf("%s configmap not found.", internal.AdminGatesConfigMap) - } else if err != nil { + } else { message = fmt.Sprintf("Unable to access configmap %s, err=%v.", internal.AdminGatesConfigMap, err) } klog.Error(message) @@ -394,7 +394,7 @@ func (check *clusterAdminAcksCompletedUpgradeable) Check() *configv1.ClusterOper var message string if apierrors.IsNotFound(err) { message = fmt.Sprintf("%s configmap not found.", internal.AdminAcksConfigMap) - } else if err != nil { + } else { message = fmt.Sprintf("Unable to access configmap %s, err=%v.", internal.AdminAcksConfigMap, err) } klog.Error(message)