From 6f270d2a6188278f8c13b9cb29c1a2e96b98f685 Mon Sep 17 00:00:00 2001 From: Deep Mistry Date: Fri, 5 Dec 2025 11:53:43 -0500 Subject: [PATCH 1/2] DPTP-4340: Remove direct mirroring to registry.ci.openshift.org, consolidate to single promotion step --- pkg/defaults/defaults.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/defaults/defaults.go b/pkg/defaults/defaults.go index d998ed4cfd..06ffe2023e 100644 --- a/pkg/defaults/defaults.go +++ b/pkg/defaults/defaults.go @@ -389,7 +389,6 @@ func fromConfig( return nil, nil, fmt.Errorf("cannot promote images, no promotion configuration defined") } - promotionSteps = append(promotionSteps, releasesteps.PromotionStep(api.PromotionStepName, config, requiredNames, jobSpec, podClient, pushSecret, registryDomain(config.PromotionConfiguration), api.DefaultMirrorFunc, api.DefaultTargetNameFunc, nodeArchitectures)) // Used primarily (only?) by the ci-chat-bot if config.PromotionConfiguration.RegistryOverride != "" { logrus.Info("No images to promote to quay.io if the registry is overridden") From 661cd2f9f5d5ea27fac1fea59868dd58b993b483 Mon Sep 17 00:00:00 2001 From: Deep Mistry Date: Fri, 5 Dec 2025 13:21:53 -0500 Subject: [PATCH 2/2] Fix unit test: update expected promotion steps after removing direct mirroring --- pkg/defaults/defaults_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/defaults/defaults_test.go b/pkg/defaults/defaults_test.go index 42647a4cab..dd1445709c 100644 --- a/pkg/defaults/defaults_test.go +++ b/pkg/defaults/defaults_test.go @@ -1733,7 +1733,7 @@ func TestFromConfig(t *testing.T) { }, promote: true, expectedSteps: []string{"[output-images]", "[images]"}, - expectedPost: []string{"[promotion]", "[promotion-quay]"}, + expectedPost: []string{"[promotion-quay]"}, }, { name: "duplicate input images", config: api.ReleaseBuildConfiguration{