Skip to content

Add override-snapshot generation to CRS pipeline#964

Open
dsimansk wants to merge 2 commits into
openshift-knative:mainfrom
dsimansk:pr/add-override-snaphot
Open

Add override-snapshot generation to CRS pipeline#964
dsimansk wants to merge 2 commits into
openshift-knative:mainfrom
dsimansk:pr/add-override-snaphot

Conversation

@dsimansk

Copy link
Copy Markdown
Contributor

On the S-O side we can drop periodic genration of override-snapshot.yaml file.

It's only needed whenever being applied, so we can just generated it mid-flight. Wdyt?

/cc @creydr @Kaustubh-pande

@dsimansk

Copy link
Copy Markdown
Contributor Author

/hold

@Kaustubh-pande

Copy link
Copy Markdown
Collaborator

Good call, it will also reduce a lot of unnecessary snapshot updates.
/lgtm
/approve

feel free to unhold this.

@openshift-ci

openshift-ci Bot commented May 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, Kaustubh-pande

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Kaustubh-pande,dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr

creydr commented May 20, 2026

Copy link
Copy Markdown
Collaborator

I think one reason why we generate it the current way, was to have them persisted in Git and thus see directly which component versions a release has (as background information)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants