handle a case where there's multiple values mapped to same type

Author: eli-bl

end_to_end_tests/baseline_openapi_3.0.json

@@ -2823,7 +2823,8 @@
           "propertyName": "modelType",
           "mapping": {
             "type1": "#/components/schemas/ADiscriminatedUnionType1",
-            "type2": "#/components/schemas/ADiscriminatedUnionType2"
+            "type2": "#/components/schemas/ADiscriminatedUnionType2",
+            "type2-another-value": "#/components/schemas/ADiscriminatedUnionType2"
           }
         },
         "oneOf": [

end_to_end_tests/baseline_openapi_3.1.yaml

@@ -2817,7 +2817,8 @@ info:
         "propertyName": "modelType",
         "mapping": {
           "type1": "#/components/schemas/ADiscriminatedUnionType1",
-          "type2": "#/components/schemas/ADiscriminatedUnionType2"
+          "type2": "#/components/schemas/ADiscriminatedUnionType2",
+          "type2-another-value": "#/components/schemas/ADiscriminatedUnionType2"
         }
       },
       "oneOf": [

end_to_end_tests/golden-record/my_test_api_client/models/model_with_discriminated_union.py

@@ -78,9 +78,17 @@ def _parse_2(data: object) -> ADiscriminatedUnionType2:
 
                     return componentsschemas_a_discriminated_union_type_1
 
+                def _parse_3(data: object) -> ADiscriminatedUnionType2:
+                    if not isinstance(data, dict):
+                        raise TypeError()
+                    componentsschemas_a_discriminated_union_type_1 = ADiscriminatedUnionType2.from_dict(data)
+
+                    return componentsschemas_a_discriminated_union_type_1
+
                 _discriminator_mapping = {
                     "type1": _parse_1,
                     "type2": _parse_2,
+                    "type2-another-value": _parse_3,
                 }
                 if _parse_fn := _discriminator_mapping.get(_discriminator_value):
                     return cast(

openapi_python_client/parser/properties/union.py

@@ -308,7 +308,9 @@ def _get_model_name(model: ModelProperty) -> str | None:
                     detail=f'Discriminator mapping referred to "{name}" which is not one of the schema variants',
                 )
             mapping[discriminator_value] = mapped_model
-            unspecified_models.remove(mapped_model)
+            if mapped_model in unspecified_models:
+                # could've already been removed if more than one value is mapped to the same model
+                unspecified_models.remove(mapped_model)
     for model in unspecified_models:
         if name := _get_model_name(model):
             mapping[name] = model