Add flake8 checking, break CI checks into individual steps.

Author: dbanty

.circleci/config.yml

@@ -23,16 +23,37 @@ jobs:
             poetry install
 
       - run:
-          name: Run Tests
-          command: |
-            mkdir -p test-reports/safety test-reports/mypy test-reports/pytest
-            poetry run black . --check
-            poetry run isort . --check
-            poetry run safety check --json > test-reports/safety/results.json
-            poetry run mypy openapi_python_client --junit-xml=test-reports/mypy/results.xml
-            poetry run pytest --junitxml=test-reports/pytest/results.xml --cov=openapi_python_client tests
-            poetry run pytest end_to_end_tests
-            poetry run coverage xml
+          name: Create Test Results Dir
+          command: mkdir -p test-reports/safety test-reports/mypy test-reports/pytest
+
+      - run:
+          name: Black
+          command: poetry run black . --check
+
+      - run:
+          name: isort
+          command: poetry run isort . --check
+
+      - run:
+          name: Safety
+          command: poetry run safety check --json > test-reports/safety/results.json
+
+      - run:
+          name: mypy
+          command: poetry run mypy openapi_python_client --junit-xml=test-reports/mypy/results.xml
+
+      - run:
+          name: Unit Tests
+          command: poetry run pytest --junitxml=test-reports/pytest/results.xml --cov=openapi_python_client tests
+
+      - run:
+          name: End to End Test
+          command: poetry run pytest end_to_end_tests
+
+      - run:
+          name: Generate Coverage Report
+          command: poetry run coverage xml
+
       - store_test_results:
           path: test-reports
       - codecov/upload:

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+max-line-length = 120

openapi_python_client/cli.py

@@ -26,7 +26,7 @@ def _process_config(path: Optional[pathlib.Path]) -> None:
 
     try:
         load_config(path=path)
-    except:
+    except:  # noqa
         raise typer.BadParameter("Unable to parse config")
 
 

openapi_python_client/openapi_parser/__init__.py

@@ -1,3 +1,5 @@
 """ Classes representing the data in the OpenAPI schema """
 
+__all__ = ["OpenAPI", "import_string_from_reference"]
+
 from .openapi import OpenAPI, import_string_from_reference

openapi_python_client/openapi_parser/openapi.py

@@ -2,7 +2,7 @@
 
 from dataclasses import dataclass, field
 from enum import Enum
-from typing import Any, Dict, Generator, Iterable, List, Optional, Set
+from typing import Any, Dict, List, Optional, Set
 
 from .errors import ParseError
 from .properties import EnumProperty, Property, property_from_dict
@@ -171,8 +171,11 @@ class Schema:
     @staticmethod
     def from_dict(d: Dict[str, Any], name: str) -> Schema:
         """ A single Schema from its dict representation
-        :param d:    Dict representation of the schema
-        :param name: Name by which the schema is referenced, such as a model name.  Used to infer the type name if a `title` property is not available.
+
+        Args:
+            d:    Dict representation of the schema
+            name: Name by which the schema is referenced, such as a model name.
+                Used to infer the type name if a `title` property is not available.
         """
         required_set = set(d.get("required", []))
         required_properties: List[Property] = []

openapi_python_client/openapi_parser/properties.py

@@ -97,9 +97,7 @@ def get_imports(self, *, prefix: str) -> Set[str]:
             prefix: A prefix to put before any relative (local) module names.
         """
         imports = super().get_imports(prefix=prefix)
-        imports.update(
-            {"from datetime import datetime", "from typing import cast",}
-        )
+        imports.update({"from datetime import datetime", "from typing import cast"})
         return imports
 
 
@@ -118,9 +116,7 @@ def get_imports(self, *, prefix: str) -> Set[str]:
             prefix: A prefix to put before any relative (local) module names.
         """
         imports = super().get_imports(prefix=prefix)
-        imports.update(
-            {"from datetime import date", "from typing import cast",}
-        )
+        imports.update({"from datetime import date", "from typing import cast"})
         return imports
 
 
@@ -286,11 +282,11 @@ def get_imports(self, *, prefix: str) -> Set[str]:
         return imports
 
     @staticmethod
-    def values_from_list(l: List[str]) -> Dict[str, str]:
+    def values_from_list(values: List[str]) -> Dict[str, str]:
         """ Convert a list of values into dict of {name: value} """
         output: Dict[str, str] = {}
 
-        for i, value in enumerate(l):
+        for i, value in enumerate(values):
             if value[0].isalpha():
                 key = value.upper()
             else:

poetry.lock

@@ -45,12 +45,14 @@ pytest-cov = "*"
 fastapi = "*"
 uvicorn = "*"
 python-multipart = "*"
+flake8 = "^3.8.3"
 
 [tool.taskipy.tasks]
 check = """
 isort .\
  && black .\
- && safety check\
+ && flake8 openapi_python_client\
+ && safety check --bare\
  && mypy openapi_python_client\
  && pytest --cov openapi_python_client tests\
 """