restore some missing test coverage

Author: eli-bl

end_to_end_tests/end_to_end_test_helpers.py

@@ -78,18 +78,17 @@ def generate_client(
     extra_args: List[str] = [],
     output_path: str = "my-test-api-client",
     base_module: str = "my_test_api_client",
+    specify_output_path_explicitly: bool = True,
     overwrite: bool = True,
     raise_on_error: bool = True,
 ) -> GeneratedClientContext:
     """Run the generator and return a GeneratedClientContext for accessing the generated code."""
     full_output_path = Path.cwd() / output_path
     if not overwrite:
         shutil.rmtree(full_output_path, ignore_errors=True)
-    args = [
-        *extra_args,
-        "--output-path",
-        str(full_output_path),
-    ]
+    args = extra_args
+    if specify_output_path_explicitly:
+        args = [*args, "--output-path", str(full_output_path)]
     if overwrite:
         args = [*args, "--overwrite"]
     generator_result = _run_command("generate", args, openapi_document, raise_on_error=raise_on_error)

end_to_end_tests/test_end_to_end.py

@@ -86,8 +86,9 @@ def run_e2e_test(
     golden_record_path: str = "golden-record",
     output_path: str = "my-test-api-client",
     expected_missing: Optional[Set[str]] = None,
+    specify_output_path_explicitly: bool = True,
 ) -> Result:
-    with generate_client(openapi_document, extra_args, output_path) as g:
+    with generate_client(openapi_document, extra_args, output_path, specify_output_path_explicitly=specify_output_path_explicitly) as g:
         gr_path = Path(__file__).parent / golden_record_path
 
         expected_differences = expected_differences or {}
@@ -165,6 +166,7 @@ def test_none_meta():
         golden_record_path="test-3-1-golden-record/test_3_1_features_client",
         output_path="test_3_1_features_client",
         expected_missing={"py.typed"},
+        specify_output_path_explicitly=False,
     )