Skip to content

Commit 4e66ecb

Browse files
viacheslauKviacheslauK
committed
unused variable
1 parent bcb8377 commit 4e66ecb

11 files changed

+31
-13
lines changed

‎modules/mqtt_streaming_module/include/mqtt_streaming_module/atomic_signal_atomic_sample_handler.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class AtomicSignalAtomicSampleHandler : public HandlerBase
2828

2929
MqttData processSignalContexts(std::vector<SignalContext>& signalContexts) override;
3030
ProcedureStatus validateSignalContexts(const std::vector<SignalContext>& signalContexts) const override;
31-
ProcedureStatus signalListChanged(std::vector<SignalContext>& signalContexts) override
31+
ProcedureStatus signalListChanged(std::vector<SignalContext>&) override
3232
{
3333
return ProcedureStatus{true, {}};
3434
};

‎modules/mqtt_streaming_module/src/atomic_signal_atomic_sample_handler.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ MqttData AtomicSignalAtomicSampleHandler::processSignalContext(SignalContext& si
119119
return messages;
120120
}
121121

122-
void AtomicSignalAtomicSampleHandler::processSignalDescriptorChanged(SignalContext& signalCtx,
123-
const DataDescriptorPtr& valueSigDesc,
124-
const DataDescriptorPtr& domainSigDesc)
122+
void AtomicSignalAtomicSampleHandler::processSignalDescriptorChanged(SignalContext&,
123+
const DataDescriptorPtr&,
124+
const DataDescriptorPtr&)
125125
{
126126
}
127127

‎modules/mqtt_streaming_module/src/atomic_signal_sample_arr_handler.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ std::pair<DataPacketPtr, size_t> AtomicSignalSampleArrayHandler::getSample(Signa
107107
}
108108

109109
void AtomicSignalSampleArrayHandler::processSignalDescriptorChanged(SignalContext& signalCtx,
110-
const DataDescriptorPtr& valueSigDesc,
111-
const DataDescriptorPtr& domainSigDesc)
110+
const DataDescriptorPtr&,
111+
const DataDescriptorPtr&)
112112
{
113113
signalBuffers[signalCtx.inputPort.getSignal().getGlobalId().toStdString()].clear();
114114
}

‎modules/mqtt_streaming_module/src/group_signal_shared_ts_handler.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ ProcedureStatus GroupSignalSharedTsHandler::signalListChanged(std::vector<Signal
228228
return status;
229229
}
230230

231-
ListPtr<IString> GroupSignalSharedTsHandler::getTopics(const std::vector<SignalContext>& signalContexts)
231+
ListPtr<IString> GroupSignalSharedTsHandler::getTopics(const std::vector<SignalContext>&)
232232
{
233233
auto res = List<IString>(String(buildTopicName()));
234234
return res;

‎modules/mqtt_streaming_module/src/mqtt_json_decoder_fb_impl.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void MqttJsonDecoderFbImpl::initProperties(const PropertyObjectPtr& config)
7474
objPtr.addProperty(internalProp.clone());
7575
objPtr.setPropertyValue(propName, prop.getValue());
7676
objPtr.getOnPropertyValueWrite(prop.getName()) +=
77-
[this](PropertyObjectPtr& obj, PropertyValueEventArgsPtr& args) { propertyChanged(); };
77+
[this](PropertyObjectPtr&, PropertyValueEventArgsPtr&) { propertyChanged(); };
7878
}
7979
}
8080
else

‎modules/mqtt_streaming_module/src/mqtt_streaming_module_impl.cpp‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ MqttStreamingModule::onCreateFunctionBlock(const StringPtr& id,
4141
const StringPtr& localId,
4242
const PropertyObjectPtr& config)
4343
{
44+
(void)id;
45+
(void)localId;
4446
if (!context.assigned())
4547
DAQ_THROW_EXCEPTION(InvalidParameterException, "Context is not available.");
4648

‎modules/mqtt_streaming_module/src/mqtt_subscriber_fb_impl.cpp‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#include "mqtt_streaming_module/constants.h"
22
#include <boost/algorithm/string.hpp>
33
#include <fstream>
4+
#include <iostream>
45
#include <mqtt_streaming_module/helper.h>
56
#include <mqtt_streaming_module/mqtt_json_decoder_fb_impl.h>
67
#include <mqtt_streaming_module/mqtt_subscriber_fb_impl.h>
@@ -408,7 +409,10 @@ void MqttSubscriberFbImpl::processMessage(const mqtt::MqttMessage& msg)
408409

409410
if (enablePreview)
410411
{
411-
const auto outputPacket = BinaryDataPacket(nullptr, outputSignal.getDescriptor(), msg.getData().size());
412+
const auto signalDsc = outputSignal.getDescriptor();
413+
const auto signalDscST = signalDsc.getSampleType();
414+
std::cout << "daq::SampleType: " << static_cast<int>(signalDscST) << std::endl;
415+
const auto outputPacket = BinaryDataPacket(nullptr, signalDsc, msg.getData().size());
412416
memcpy(outputPacket.getData(), msg.getData().data(), msg.getData().size());
413417
outputSignal.sendPacket(outputPacket);
414418
}
@@ -430,6 +434,7 @@ void MqttSubscriberFbImpl::createSignals()
430434
if (enablePreview)
431435
{
432436
const auto signalDsc = DataDescriptorBuilder().setSampleType(previewIsString ? SampleType::String : SampleType::Binary).build();
437+
std::cout << "SET daq::SampleType: " << static_cast<int>(signalDsc.getSampleType()) << std::endl;
433438
outputSignal = createAndAddSignal(DEFAULT_VALUE_SIGNAL_LOCAL_ID, signalDsc);
434439
}
435440
}

‎modules/mqtt_streaming_module/src/signal_arr_atomic_sample_handler.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,12 @@ ProcedureStatus SignalArrayAtomicSampleHandler::validateSignalContexts(const std
116116
return status;
117117
}
118118

119-
ProcedureStatus SignalArrayAtomicSampleHandler::signalListChanged(std::vector<SignalContext>& signalContexts)
119+
ProcedureStatus SignalArrayAtomicSampleHandler::signalListChanged(std::vector<SignalContext>&)
120120
{
121121
return ProcedureStatus{true, {}};
122122
}
123123

124-
ListPtr<IString> SignalArrayAtomicSampleHandler::getTopics(const std::vector<SignalContext>& signalContexts)
124+
ListPtr<IString> SignalArrayAtomicSampleHandler::getTopics(const std::vector<SignalContext>&)
125125
{
126126
auto res = List<IString>(String(buildTopicName()));
127127
return res;

‎shared/mqtt_streaming_protocol/src/MqttAsyncClient.cpp‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ void MqttAsyncClient::onDeliveryCompleted(void* context, MQTTAsync_token token)
278278

279279
void MqttAsyncClient::onConnected(void* context, char* cause)
280280
{
281+
(void)cause;
281282
if (context != nullptr)
282283
{
283284
auto clienttInst = (MqttAsyncClient*)context;
@@ -304,6 +305,7 @@ void MqttAsyncClient::onConnectionLost(void* context, char* cause)
304305

305306
int MqttAsyncClient::onMsgArrived(void* context, char* topicName, int topicLen, MQTTAsync_message* message)
306307
{
308+
(void)topicLen;
307309
if (context != nullptr && message != nullptr)
308310
{
309311
MqttAsyncClient* client = (MqttAsyncClient*)context;
@@ -354,6 +356,7 @@ void MqttAsyncClient::onSendFailure(void* context, MQTTAsync_failureData* data)
354356

355357
void MqttAsyncClient::onConnectSuccess(void* context, MQTTAsync_successData* data)
356358
{
359+
(void)data;
357360
// TODO : check when this is called
358361
if (context != nullptr)
359362
{
@@ -364,6 +367,7 @@ void MqttAsyncClient::onConnectSuccess(void* context, MQTTAsync_successData* dat
364367

365368
void MqttAsyncClient::onConnectFailure(void* context, MQTTAsync_failureData* data)
366369
{
370+
(void)data;
367371
// TODO : check when this is called
368372
if (context != nullptr)
369373
{
@@ -374,6 +378,7 @@ void MqttAsyncClient::onConnectFailure(void* context, MQTTAsync_failureData* dat
374378

375379
void MqttAsyncClient::onDisconnectSuccess(void* context, MQTTAsync_successData* data)
376380
{
381+
(void)data;
377382
// TODO : check when this is called
378383
if (context != nullptr)
379384
{
@@ -388,6 +393,7 @@ void MqttAsyncClient::onDisconnectSuccess(void* context, MQTTAsync_successData*
388393

389394
void MqttAsyncClient::onDisconnectFailure(void* context, MQTTAsync_failureData* data)
390395
{
396+
(void)data;
391397
// TODO : check when this is called
392398
if (context != nullptr)
393399
{
@@ -402,10 +408,14 @@ void MqttAsyncClient::onDisconnectFailure(void* context, MQTTAsync_failureData*
402408

403409
void MqttAsyncClient::onSubscribeSuccess(void* context, MQTTAsync_successData* response)
404410
{
411+
(void)context;
412+
(void)response;
405413
}
406414

407415
void MqttAsyncClient::onSubscribeFailure(void* context, MQTTAsync_failureData* response)
408416
{
417+
(void)context;
418+
(void)response;
409419
}
410420

411421
void MqttAsyncClient::onUnsubscribeSuccess(void* context, MQTTAsync_successData* response)

‎shared/mqtt_streaming_protocol/tests/MqttAsyncClientWrapper.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ void MqttAsyncClientWrapper::expectMsgs(const std::string& topic,
143143
std::atomic<bool>& done)
144144
{
145145
instance->setMessageArrivedCb(topic,
146-
[topic, &done, &msgs, &promise, i = size_t(0)](const mqtt::MqttAsyncClient& subscriber,
146+
[topic, &done, &msgs, &promise, i = size_t(0)](const mqtt::MqttAsyncClient&,
147147
mqtt::MqttMessage& receivedMsg) mutable
148148
{
149149
const auto receivedStr = receivedMsg.toString();
@@ -163,7 +163,7 @@ void MqttAsyncClientWrapper::expectMultiMsgs(const std::string& topic,
163163
std::atomic<bool>& done)
164164
{
165165
instance->setMessageArrivedCb(topic,
166-
[topic, &done, localMsgs = msgs, &promise](const mqtt::MqttAsyncClient& subscriber,
166+
[topic, &done, localMsgs = msgs, &promise](const mqtt::MqttAsyncClient&,
167167
mqtt::MqttMessage& receivedMsg) mutable
168168
{
169169
const auto receivedStr = receivedMsg.toString();

0 commit comments

Comments
 (0)