From 8d7f27bcf1a32972ae9a8cabb24794ae1f1fa3a9 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Fri, 23 Jan 2026 14:00:39 +0900 Subject: [PATCH 1/2] celery: use self helper to retrieve metrics for assertion --- .../tests/test_metrics.py | 33 ++++--------------- 1 file changed, 6 insertions(+), 27 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py b/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py index f83759317b..2291a0d53a 100644 --- a/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py +++ b/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py @@ -71,43 +71,22 @@ def test_basic_metric(self): def test_metric_uninstrument(self): CeleryInstrumentor().instrument() - self.get_metrics() + metrics = self.get_metrics() self.assertEqual( - ( - self.memory_metrics_reader.get_metrics_data() - .resource_metrics[0] - .scope_metrics[0] - .metrics[0] - .data.data_points[0] - .bucket_counts[1] - ), + (metrics[0].data.data_points[0].bucket_counts[1]), 1, ) - self.get_metrics() + metrics = self.get_metrics() self.assertEqual( - ( - self.memory_metrics_reader.get_metrics_data() - .resource_metrics[0] - .scope_metrics[0] - .metrics[0] - .data.data_points[0] - .bucket_counts[1] - ), + (metrics[0].data.data_points[0].bucket_counts[1]), 2, ) CeleryInstrumentor().uninstrument() - self.get_metrics() + metrics = self.get_metrics() self.assertEqual( - ( - self.memory_metrics_reader.get_metrics_data() - .resource_metrics[0] - .scope_metrics[0] - .metrics[0] - .data.data_points[0] - .bucket_counts[1] - ), + (metrics[0].data.data_points[0].bucket_counts[1]), 2, ) From ac7815daef08cf87d05523c94df9e55353c1e9b1 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Fri, 23 Jan 2026 14:02:17 +0900 Subject: [PATCH 2/2] Manual formatting --- .../tests/test_metrics.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py b/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py index 2291a0d53a..a225b73e22 100644 --- a/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py +++ b/instrumentation/opentelemetry-instrumentation-celery/tests/test_metrics.py @@ -73,13 +73,13 @@ def test_metric_uninstrument(self): metrics = self.get_metrics() self.assertEqual( - (metrics[0].data.data_points[0].bucket_counts[1]), + metrics[0].data.data_points[0].bucket_counts[1], 1, ) metrics = self.get_metrics() self.assertEqual( - (metrics[0].data.data_points[0].bucket_counts[1]), + metrics[0].data.data_points[0].bucket_counts[1], 2, ) @@ -87,6 +87,6 @@ def test_metric_uninstrument(self): metrics = self.get_metrics() self.assertEqual( - (metrics[0].data.data_points[0].bucket_counts[1]), + metrics[0].data.data_points[0].bucket_counts[1], 2, )