more minor cleanup

Signed-off-by: Howard Pritchard <howardp@lanl.gov>

Author: hppritcha

ompi/mpi/bindings/ompi_bindings/c_type.py

@@ -1283,7 +1283,6 @@ class TypeStatusStandard(StandardABIType):
 
     @property
     def init_code(self):
-        # TODO: Need to ensure this is the correct conversion function for MPI_Status
         mangle_type = self.mangle_name('MPI_Status')
         code = [f'MPI_Status {self.tmpname};'];
         code.append(f'{ConvertFuncs.STATUS}(&{self.tmpname}, ({mangle_type} *){self.name});')
@@ -1457,7 +1456,6 @@ def type_text(self, enable_count=False):
         return 'MPI_F08_status *'
 
 
-# TODO: For now this just assumes that MPI_Fint doesn't need any conversions
 @Type.add_type('FINT')
 class TypeFint(Type):
 
@@ -1840,8 +1838,6 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('COPY_FUNCTION', abi_type=['standard'])
 class TypeCopyFunctionStandard(StandardABIType):
-    # TODO: This may require a special function to wrap the callback
-#    pass
 
     def type_text(self, enable_count=False):
         return 'MPI_Copy_function *'
@@ -1855,8 +1851,7 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('DELETE_FUNCTION', abi_type=['standard'])
 class TypeDeleteFunctionStandard(StandardABIType):
-    # TODO: This may require a special function to wrap the callback
-#    pass
+
     def type_text(self, enable_count=False):
         return 'MPI_Delete_function *'
 
@@ -1874,8 +1869,6 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('USER_FUNCTION', abi_type=['standard'])
 class TypeUserFunctionStandard(Type):
-    # TODO: This may require a special function to wrap the callback
-#    pass
 
     def type_text(self, enable_count=False):
         return 'MPI_User_function_c *' if enable_count else 'MPI_User_function *'
@@ -1987,8 +1980,6 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('GREQUEST_QUERY_FUNCTION', abi_type=['standard'])
 class TypeGrequestQueryFunctionStandard(Type):
-    # TODO: This may require a special function to wrap the callback
-#    pass
 
     def type_text(self, enable_count=False):
         return 'MPI_Grequest_query_function *'
@@ -2002,8 +1993,6 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('GREQUEST_FREE_FUNCTION', abi_type=['standard'])
 class TypeGrequestFreeFunctionStandard(Type):
-    # TODO: This may require a special function to wrap the callback
-#    pass
 
     def type_text(self, enable_count=False):
         return 'MPI_Grequest_free_function *'
@@ -2017,8 +2006,6 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('GREQUEST_CANCEL_FUNCTION', abi_type=['standard'])
 class TypeGrequestCancelFunctionStandard(Type):
-    # TODO: This may require a special function to wrap the callback
-#    pass
 
     def type_text(self, enable_count=False):
         return 'MPI_Grequest_cancel_function *'
@@ -2035,8 +2022,6 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('DATAREP_CONVERSION_FUNCTION', abi_type=['standard'])
 class TypeDatarepConversionFunctionStandard(Type):
-# TODO: This may require a special function to wrap the callback
-#    pass
 
     @property
     def is_count(self):
@@ -2054,8 +2039,6 @@ def type_text(self, enable_count=False):
 
 @Type.add_type('DATAREP_EXTENT_FUNCTION', abi_type=['standard'])
 class TypeDatarepExtentFunctionStandard(Type):
-    # TODO: This may require a special function to wrap the callback
-#     pass
 
     def type_text(self, enable_count=False):
         return 'MPI_Datarep_extent_function *'
@@ -3118,7 +3101,7 @@ def parameter(self, enable_count=False, **kwargs):
 # better as arg to the converter code.
 #
 @Type.add_type('WEIGHTS', abi_type=['standard'])
-class TyperWeightStandard(StandardABIType):
+class TypeWeightStandard(StandardABIType):
 
     @property
     def init_code(self):
@@ -3141,7 +3124,7 @@ def type_text(self, enable_count=False):
         return 'int *'
 
 @Type.add_type('COMM_CMP_OUT', abi_type=['standard'])
-class TyperCommCmpOutStandard(StandardABIType):
+class TypeCommCmpOutStandard(StandardABIType):
 
     @property
     def final_code(self):

ompi/mpi/c/abi.h.in

@@ -16,7 +16,6 @@ extern "C" {
 #define MPI_ABI_VERSION    1
 #define MPI_ABI_SUBVERSION 0
 
-/* TODO: add comment why this is hardcoded to avoid extra generation logic */
 typedef struct MPI_ABI_Comm * MPI_Comm;
 typedef struct MPI_ABI_Datatype * MPI_Datatype;
 typedef struct MPI_ABI_Errhandler * MPI_Errhandler;

ompi/mpi/c/comm_get_attr.c.in

@@ -71,9 +71,6 @@ PROTOTYPE ERROR_CLASS comm_get_attr(COMM comm, ATTR_KEY comm_keyval,
         } else if (MPI_IO == comm_keyval) {
             *(int **)attribute_val = &ompi_abi_mpi_any_source_val;
         } else if (MPI_LASTUSEDCODE == comm_keyval) {
-          /*
-           * TODO: is this locking good enough?
-           */
           OPAL_THREAD_LOCK(&comm->c_lock);
           ompi_abi_mpi_lastusedcode = ompi_convert_intern_error_abi_error(*(int *)*(void**)attribute_val);
           OPAL_THREAD_UNLOCK(&comm->c_lock);