feat: optionally disable exceptions on evaluation errors

Signed-off-by: Danju Visvanathan <danju.visvanathan@gmail.com>

Author: danjuv

hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py

@@ -3,7 +3,7 @@
 from openfeature.exception import ErrorCode
 from openfeature.flag_evaluation import FlagEvaluationDetails, Reason
 from openfeature.hook import Hook, HookContext, HookHints
-from opentelemetry import metrics, trace
+from opentelemetry import trace
 from opentelemetry.semconv.attributes.error_attributes import ERROR_TYPE
 
 OTEL_EVENT_NAME = "feature_flag.evaluation"
@@ -21,6 +21,9 @@ class EventAttributes:
 
 
 class TracingHook(Hook):
+    def __init__(self, exclude_exceptions: bool = False):
+        self.exclude_exceptions = exclude_exceptions
+
     def finally_after(
         self,
         hook_context: HookContext,
@@ -60,6 +63,8 @@ def finally_after(
     def error(
         self, hook_context: HookContext, exception: Exception, hints: HookHints
     ) -> None:
+        if self.exclude_exceptions:
+            return
         attributes = {
             EventAttributes.KEY: hook_context.flag_key,
             EventAttributes.RESULT_VALUE: json.dumps(hook_context.default_value),

hooks/openfeature-hooks-opentelemetry/tests/test_otel.py

@@ -12,12 +12,14 @@
 from openfeature.provider.metadata import Metadata
 
 
+
+
 @pytest.fixture
 def mock_get_current_span(monkeypatch):
     monkeypatch.setattr(trace, "get_current_span", Mock())
 
 
-def test_after(mock_get_current_span):
+def test_finally_after(mock_get_current_span):
     # Given
     hook = TracingHook()
     hook_context = HookContext(
@@ -40,7 +42,7 @@ def test_after(mock_get_current_span):
     trace.get_current_span.return_value = mock_span
 
     # When
-    hook.after(hook_context, details, hints={})
+    hook.finally_after(hook_context, details, hints={})
 
     # Then
     mock_span.add_event.assert_called_once_with(
@@ -79,7 +81,7 @@ def test_after_evaluation_error(mock_get_current_span):
     trace.get_current_span.return_value = mock_span
 
     # When
-    hook.after(hook_context, details, hints={})
+    hook.finally_after(hook_context, details, hints={})
 
     # Then
     mock_span.add_event.assert_called_once_with(
@@ -104,6 +106,10 @@ def test_error(mock_get_current_span):
         evaluation_context=EvaluationContext(),
     )
     exception = Exception()
+    attributes = {
+        "feature_flag.key": "flag_key",
+        "feature_flag.result.value": "false",
+    }
 
     mock_span = Mock(spec=Span)
     trace.get_current_span.return_value = mock_span
@@ -112,4 +118,23 @@ def test_error(mock_get_current_span):
     hook.error(hook_context, exception, hints={})
 
     # Then
-    mock_span.record_exception.assert_called_once_with(exception)
+    mock_span.record_exception.assert_called_once_with(exception, attributes)
+
+def test_error_exclude_exceptions(mock_get_current_span):
+    # Given
+    hook = TracingHook(exclude_exceptions=True)
+    hook_context = HookContext(
+        flag_key="flag_key",
+        flag_type=FlagType.BOOLEAN,
+        default_value=False,
+        evaluation_context=EvaluationContext(),
+    )
+    exception = Exception()
+
+    mock_span = Mock(spec=Span)
+    trace.get_current_span.return_value = mock_span
+
+    # When
+    hook.error(hook_context, exception, hints={})
+
+    mock_span.record_exception.assert_not_called()