diff --git a/codeql_issue_testruleset2.py b/codeql_issue_testruleset2.py new file mode 100644 index 0000000..9d76984 --- /dev/null +++ b/codeql_issue_testruleset2.py @@ -0,0 +1,22 @@ +import os +from flask import request, Flask +import re + + +# Clear-text logging of sensitive information +# did not trigger an alert in codeQL somehow... +print(f"[INFO] Environment: {os.environ}") + +# attempt to trigger a warning in codeQL +# Regular expression injection +@app.route("/direct") +def direct(): + unsafe_pattern = request.args["pattern"] + re.search(unsafe_pattern, "") + + +@app.route("/compile") +def compile(): + unsafe_pattern = request.args["pattern"] + compiled_pattern = re.compile(unsafe_pattern) + compiled_pattern.search("") diff --git a/regex.py b/regex.py index 3befaba..909ed9d 100644 --- a/regex.py +++ b/regex.py @@ -6,10 +6,3 @@ def direct(): unsafe_pattern = request.args["pattern"] re.search(unsafe_pattern, "") - - -@app.route("/compile") -def compile(): - unsafe_pattern = request.args["pattern"] - compiled_pattern = re.compile(unsafe_pattern) - compiled_pattern.search("")