Fixes for compiling bootloader on Solaris 10 systems (pyinstaller#9171)

* exclude libsocket.so as this is specific to the Solaris installation and causes symbol errors otherwise
* add identifier for SPARC vs Intel as bootloaders built on one do not work on the other
* add definition for wcsdup which is not available on Solaris 10u11

Author: JordanStopford

PyInstaller/_shared_with_waf.py

@@ -51,6 +51,12 @@ def _pyi_machine(machine, system):
         else:
             return "intel"
 
+    if system == "SunOS":
+        if machine.lower() in ("x86", "i86pc"):
+            return "intel"
+        else:
+            return "sparc"
+
     if system != "Linux":
         # No architecture specifier for anything par Linux.
         # - macOS is on two 64 bit architectures, but they are merged into one "universal2" bootloader.

PyInstaller/depend/dylib.py

@@ -237,6 +237,10 @@
     r'libz\.a',
 }
 
+_solaris_excludes = {
+    r'libsocket\.so(\..*)?',
+}
+
 _cygwin_excludes = {
     r'cygwin1\.dll',
 }
@@ -249,6 +253,10 @@
 elif compat.is_aix:
     # The exclude list for AIX differs from other *nix platforms.
     _excludes |= _aix_excludes
+elif compat.is_solar:
+    # The exclude list for Solaris differs from other *nix platforms.
+    _excludes |= _solaris_excludes
+    _excludes |= _unix_excludes
 elif compat.is_unix:
     # Common excludes for *nix platforms -- except AIX.
     _excludes |= _unix_excludes

bootloader/src/pyi_pyconfig.c

@@ -24,6 +24,18 @@
 #include "pyi_main.h"
 #include "pyi_utils.h"
 
+#ifndef HAVE_WCSDUP
+static wchar_t
+*wcsdup(const wchar_t *s)
+{
+    size_t len = wcslen(s) + 1;
+    wchar_t *new_s = malloc(len * sizeof(wchar_t));
+    if (new_s) {
+        wcscpy(new_s, s);
+    }
+    return new_s;
+}
+#endif
 
 /*
  * Clean up and free the PyiRuntimeOptions structure created by

bootloader/wscript

@@ -686,6 +686,7 @@ def configure(ctx):
         ('unistd.h' if ctx.env.DEST_OS == 'darwin' else 'stdlib.h', 'mkdtemp'),
         ('libgen.h', 'dirname'),
         ('libgen.h', 'basename'),
+        ('wchar.h', 'wcsdup')
     ):
         ctx.check(
             fragment=SNIP_FUNCTION % (header, function_name),