Refactor API and contract structure; move HTTP server and data engine interfaces to @objectstack/core, remove deprecated files

Author: hotlong

packages/core/src/contracts/data-engine.ts

@@ -0,0 +1,47 @@
+/**
+ * IDataEngine - Standard Data Engine Interface
+ * 
+ * Abstract interface for data persistence capabilities.
+ * Following the Dependency Inversion Principle - plugins depend on this interface,
+ * not on concrete database implementations.
+ */
+
+export interface DataEngineFilter {
+  [key: string]: any;
+}
+
+export interface DataEngineQueryOptions {
+  /** Filter conditions */
+  filter?: DataEngineFilter;
+  /** Fields to select */
+  select?: string[];
+  /** Sort order */
+  sort?: Record<string, 1 | -1 | 'asc' | 'desc'>;
+  /** Limit number of results */
+  limit?: number;
+  /** Skip number of results */
+  skip?: number;
+  /** Maximum number of results */
+  top?: number;
+}
+
+export interface IDataEngine {
+  insert(objectName: string, data: any): Promise<any>;
+  find(objectName: string, query?: DataEngineQueryOptions): Promise<any[]>;
+  update(objectName: string, id: any, data: any): Promise<any>;
+  delete(objectName: string, id: any): Promise<boolean>;
+}
+
+// Driver Interface specific to storage drivers
+export interface DriverOptions {
+  name?: string;
+  url?: string;
+  [key: string]: any;
+}
+
+export interface DriverInterface extends IDataEngine {
+  name: string;
+  version: string;
+  connect(): Promise<void>;
+  disconnect(): Promise<void>;
+}

packages/spec/src/api/http-server.ts …ckages/core/src/contracts/http-server.tspackages/spec/src/api/http-server.ts renamed to packages/core/src/contracts/http-server.ts packages/spec/src/api/http-server.ts renamed to packages/core/src/contracts/http-server.ts

@@ -1,2 +1,4 @@
 export * from './kernel.js';
 export * from './types.js';
+export * from './contracts/http-server.js';
+export * from './contracts/data-engine.js';

packages/core/src/index.ts

@@ -14,6 +14,5 @@ export * from './realtime.zod';
 export * from './router.zod';
 export * from './odata.zod';
 
-export * from './http-server';
 export * from './protocol';
 

packages/spec/src/api/index.ts

@@ -39,69 +39,19 @@ export const DataEngineQueryOptionsSchema = z.object({
  * Data Engine Interface Schema
  * 
  * Defines the contract for data engine implementations.
+ * (Deprecated: Moved to @objectstack/core/contracts/data-engine)
  */
+/*
 export const DataEngineSchema = z.object({
-  /**
-   * Insert a new record
-   * 
-   * @param objectName - Name of the object/table (e.g., 'user', 'order')
-   * @param data - Data to insert
-   * @returns Promise resolving to the created record (including generated ID)
-   */
-  insert: z.function()
-    .args(z.string(), z.any())
-    .returns(z.promise(z.any()))
-    .describe('Insert a new record'),
-  
-  /**
-   * Find records matching a query
-   * 
-   * @param objectName - Name of the object/table
-   * @param query - Query conditions (optional)
-   * @returns Promise resolving to an array of matching records
-   */
-  find: z.function()
-    .args(z.string())
-    .returns(z.promise(z.array(z.any())))
-    .describe('Find records matching a query'),
-  
-  /**
-   * Update a record by ID
-   * 
-   * @param objectName - Name of the object/table
-   * @param id - Record ID
-   * @param data - Updated data (partial update)
-   * @returns Promise resolving to the updated record
-   */
-  update: z.function()
-    .args(z.string(), z.any(), z.any())
-    .returns(z.promise(z.any()))
-    .describe('Update a record by ID'),
-  
-  /**
-   * Delete a record by ID
-   * 
-   * @param objectName - Name of the object/table
-   * @param id - Record ID
-   * @returns Promise resolving to true if deleted, false otherwise
-   */
-  delete: z.function()
-    .args(z.string(), z.any())
-    .returns(z.promise(z.boolean()))
-    .describe('Delete a record by ID'),
+  ...
 }).describe('Data Engine Interface');
+*/
 
 /**
  * TypeScript types derived from schemas
  */
 export type DataEngineFilter = z.infer<typeof DataEngineFilterSchema>;
 export type DataEngineQueryOptions = z.infer<typeof DataEngineQueryOptionsSchema>;
 
-// Define the TypeScript interface manually for better type safety
-// Zod function schema doesn't handle optional parameters well
-export interface IDataEngine {
-  insert(objectName: string, data: any): Promise<any>;
-  find(objectName: string, query?: DataEngineQueryOptions): Promise<any[]>;
-  update(objectName: string, id: any, data: any): Promise<any>;
-  delete(objectName: string, id: any): Promise<boolean>;
-}
+// Moved IDataEngine interface to @objectstack/core to separate runtime contract from data schema
+// Moved IDataEngine interface to @objectstack/core to separate runtime contract from data schema

packages/spec/src/system/data-engine.zod.ts

@@ -16,7 +16,7 @@ export * from './types';
 
 // Re-export Core System Definitions
 export * from './manifest.zod';
-export * from './plugin.zod';
+// export * from './plugin.zod'; // Moved to @objectstack/core
 export * from './logger.zod';
 export * from './context.zod';
 export * from './scoped-storage.zod';