Merge pull request #872 from objectstack-ai/copilot/fix-analytics-service-method-naming

Author: hotlong

ROADMAP.md

@@ -125,6 +125,7 @@ This strategy ensures rapid iteration while maintaining a clear path to producti
 | DashboardWidget discriminated union by type | 🔴 | Planned — chart/metric/pivot subtypes with type-specific required fields |
 | CI lint rule rejecting new `z.any()` | 🔴 | Planned — eslint or custom lint rule to block `z.any()` additions |
 | Dispatcher async `getService` bug fix | ✅ | All `getService`/`getObjectQLService` calls in `http-dispatcher.ts` now properly `await` async service factories. Covers `handleAnalytics`, `handleAuth`, `handleStorage`, `handleAutomation`, `handleMetadata`, `handleUi`, `handlePackages`. All 7 framework adapters (Express, Fastify, Hono, Next.js, SvelteKit, NestJS, Nuxt) updated to use `getServiceAsync()` for auth service resolution. |
+| Analytics `getMetadata` → `getMeta` naming fix | ✅ | `handleAnalytics` in `http-dispatcher.ts` called `getMetadata({ request })` which didn't match the `IAnalyticsService` contract (`getMeta(cubeName?: string)`). Renamed to `getMeta()` and aligned call signature. Updated test mocks accordingly. |
 
 ---
 

packages/runtime/src/http-dispatcher.test.ts

@@ -216,7 +216,7 @@ describe('HttpDispatcher', () => {
             it('should resolve analytics service from Promise (async factory)', async () => {
                 const mockAnalytics = {
                     query: vi.fn().mockResolvedValue({ rows: [{ id: 1 }], total: 1 }),
-                    getMetadata: vi.fn().mockResolvedValue({ tables: ['t1'] }),
+                    getMeta: vi.fn().mockResolvedValue({ tables: ['t1'] }),
                     generateSql: vi.fn().mockResolvedValue({ sql: 'SELECT 1' }),
                 };
                 // Inject as Promise (simulates async factory registration)
@@ -245,7 +245,7 @@ describe('HttpDispatcher', () => {
 
             it('should handle GET /analytics/meta with async service', async () => {
                 const mockAnalytics = {
-                    getMetadata: vi.fn().mockResolvedValue({ tables: ['users', 'orders'] }),
+                    getMeta: vi.fn().mockResolvedValue({ tables: ['users', 'orders'] }),
                 };
                 (kernel as any).getService = vi.fn().mockResolvedValue(mockAnalytics);
 

packages/runtime/src/http-dispatcher.ts

@@ -526,7 +526,7 @@ export class HttpDispatcher {
      * Handles Analytics requests
      * path: sub-path after /analytics/
      */
-    async handleAnalytics(path: string, method: string, body: any, context: HttpProtocolContext): Promise<HttpDispatcherResult> {
+    async handleAnalytics(path: string, method: string, body: any, _context: HttpProtocolContext): Promise<HttpDispatcherResult> {
         const analyticsService = await this.getService(CoreServiceName.enum.analytics);
         if (!analyticsService) return { handled: false }; // 404 handled by caller if unhandled
 
@@ -535,20 +535,20 @@ export class HttpDispatcher {
 
         // POST /analytics/query
         if (subPath === 'query' && m === 'POST') {
-            const result = await analyticsService.query(body, { request: context.request });
+            const result = await analyticsService.query(body);
             return { handled: true, response: this.success(result) };
         }
 
         // GET /analytics/meta
         if (subPath === 'meta' && m === 'GET') {
-            const result = await analyticsService.getMetadata({ request: context.request });
+            const result = await analyticsService.getMeta();
              return { handled: true, response: this.success(result) };
         }
 
         // POST /analytics/sql (Dry-run or debug)
         if (subPath === 'sql' && m === 'POST') {
              // Assuming service has generateSql method
-             const result = await analyticsService.generateSql(body, { request: context.request });
+             const result = await analyticsService.generateSql(body);
              return { handled: true, response: this.success(result) };
         }