Merge pull request #632 from objectstack-ai/copilot/fix-build-and-test-again

Author: hotlong

packages/plugins/driver-memory/src/memory-analytics.ts

@@ -56,6 +56,9 @@ export class MemoryAnalyticsService implements IAnalyticsService {
     this.logger.debug('Executing analytics query', { cube: query.cube, measures: query.measures });
 
     // Get cube definition
+    if (!query.cube) {
+      throw new Error('Cube name is required');
+    }
     const cube = this.cubes.get(query.cube);
     if (!cube) {
       throw new Error(`Cube not found: ${query.cube}`);
@@ -265,6 +268,9 @@ export class MemoryAnalyticsService implements IAnalyticsService {
    * Generate SQL representation for debugging/transparency
    */
   async generateSql(query: AnalyticsQuery): Promise<{ sql: string; params: unknown[] }> {
+    if (!query.cube) {
+      throw new Error('Cube name is required');
+    }
     const cube = this.cubes.get(query.cube);
     if (!cube) {
       throw new Error(`Cube not found: ${query.cube}`);

packages/spec/src/api/protocol.zod.ts

@@ -1057,10 +1057,10 @@ export type GetMetaItemCachedResponse = z.infer<typeof GetMetaItemCachedResponse
 export type GetUiViewRequest = z.infer<typeof GetUiViewRequestSchema>;
 export type GetUiViewResponse = z.infer<typeof GetUiViewResponseSchema>;
 
-export type AnalyticsQueryRequest = z.infer<typeof AnalyticsQueryRequestSchema>;
-export type AnalyticsResultResponse = z.infer<typeof AnalyticsResultResponseSchema>;
-export type GetAnalyticsMetaRequest = z.infer<typeof GetAnalyticsMetaRequestSchema>;
-export type GetAnalyticsMetaResponse = z.infer<typeof AnalyticsMetadataResponseSchema>;
+type AnalyticsQueryRequest = z.infer<typeof AnalyticsQueryRequestSchema>;
+type AnalyticsResultResponse = z.infer<typeof AnalyticsResultResponseSchema>;
+type GetAnalyticsMetaRequest = z.infer<typeof GetAnalyticsMetaRequestSchema>;
+type GetAnalyticsMetaResponse = z.infer<typeof AnalyticsMetadataResponseSchema>;
 
 export type AutomationTriggerRequest = z.infer<typeof AutomationTriggerRequestSchema>;
 export type AutomationTriggerResponse = z.infer<typeof AutomationTriggerResponseSchema>;

packages/spec/src/contracts/analytics-service.ts

@@ -17,10 +17,10 @@
  * An analytical query definition
  */
 export interface AnalyticsQuery {
-    /** Target cube name */
-    cube: string;
+    /** Target cube name. Optional when cube is specified at a higher level (e.g. API request wrapper or cube-scoped endpoint). Implementations should validate presence at runtime. */
+    cube?: string;
     /** Measures to compute (e.g. ['orders.count', 'orders.totalRevenue']) */
-    measures?: string[];
+    measures: string[];
     /** Dimensions to group by (e.g. ['orders.status', 'orders.createdAt']) */
     dimensions?: string[];
     /** Filter conditions */