Skip to content

Commit 08dfa96

Browse files
Copilothotlong
andcommitted
Fix code review issues: improve error handling type safety
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent d61d485 commit 08dfa96

File tree

1 file changed

+34
-24
lines changed

1 file changed

+34
-24
lines changed

packages/plugin-msw/src/msw-plugin.ts

Lines changed: 34 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,11 @@ export class ObjectStackServer {
6161
status: 200,
6262
data: result
6363
};
64-
} catch (error: any) {
64+
} catch (error) {
65+
const message = error instanceof Error ? error.message : 'Unknown error';
6566
return {
6667
status: 404,
67-
data: { error: error.message }
68+
data: { error: message }
6869
};
6970
}
7071
}
@@ -81,10 +82,11 @@ export class ObjectStackServer {
8182
status: 201,
8283
data: result
8384
};
84-
} catch (error: any) {
85+
} catch (error) {
86+
const message = error instanceof Error ? error.message : 'Unknown error';
8587
return {
8688
status: 400,
87-
data: { error: error.message }
89+
data: { error: message }
8890
};
8991
}
9092
}
@@ -101,10 +103,11 @@ export class ObjectStackServer {
101103
status: 200,
102104
data: result
103105
};
104-
} catch (error: any) {
106+
} catch (error) {
107+
const message = error instanceof Error ? error.message : 'Unknown error';
105108
return {
106109
status: 400,
107-
data: { error: error.message }
110+
data: { error: message }
108111
};
109112
}
110113
}
@@ -121,10 +124,11 @@ export class ObjectStackServer {
121124
status: 200,
122125
data: result
123126
};
124-
} catch (error: any) {
127+
} catch (error) {
128+
const message = error instanceof Error ? error.message : 'Unknown error';
125129
return {
126130
status: 400,
127-
data: { error: error.message }
131+
data: { error: message }
128132
};
129133
}
130134
}
@@ -207,8 +211,9 @@ export class MSWPlugin implements RuntimePlugin {
207211
return HttpResponse.json(
208212
protocol.getMetaItem(params.type as string, params.name as string)
209213
);
210-
} catch (e: any) {
211-
return HttpResponse.json({ error: e.message }, { status: 404 });
214+
} catch (error) {
215+
const message = error instanceof Error ? error.message : 'Unknown error';
216+
return HttpResponse.json({ error: message }, { status: 404 });
212217
}
213218
}),
214219

@@ -226,8 +231,9 @@ export class MSWPlugin implements RuntimePlugin {
226231
queryParams
227232
);
228233
return HttpResponse.json(result.data, { status: result.status });
229-
} catch (e: any) {
230-
return HttpResponse.json({ error: e.message }, { status: 404 });
234+
} catch (error) {
235+
const message = error instanceof Error ? error.message : 'Unknown error';
236+
return HttpResponse.json({ error: message }, { status: 404 });
231237
}
232238
}),
233239

@@ -238,8 +244,9 @@ export class MSWPlugin implements RuntimePlugin {
238244
params.id as string
239245
);
240246
return HttpResponse.json(result.data, { status: result.status });
241-
} catch (e: any) {
242-
return HttpResponse.json({ error: e.message }, { status: 404 });
247+
} catch (error) {
248+
const message = error instanceof Error ? error.message : 'Unknown error';
249+
return HttpResponse.json({ error: message }, { status: 404 });
243250
}
244251
}),
245252

@@ -251,8 +258,9 @@ export class MSWPlugin implements RuntimePlugin {
251258
body
252259
);
253260
return HttpResponse.json(result.data, { status: result.status });
254-
} catch (e: any) {
255-
return HttpResponse.json({ error: e.message }, { status: 400 });
261+
} catch (error) {
262+
const message = error instanceof Error ? error.message : 'Unknown error';
263+
return HttpResponse.json({ error: message }, { status: 400 });
256264
}
257265
}),
258266

@@ -265,8 +273,9 @@ export class MSWPlugin implements RuntimePlugin {
265273
body
266274
);
267275
return HttpResponse.json(result.data, { status: result.status });
268-
} catch (e: any) {
269-
return HttpResponse.json({ error: e.message }, { status: 400 });
276+
} catch (error) {
277+
const message = error instanceof Error ? error.message : 'Unknown error';
278+
return HttpResponse.json({ error: message }, { status: 400 });
270279
}
271280
}),
272281

@@ -277,8 +286,9 @@ export class MSWPlugin implements RuntimePlugin {
277286
params.id as string
278287
);
279288
return HttpResponse.json(result.data, { status: result.status });
280-
} catch (e: any) {
281-
return HttpResponse.json({ error: e.message }, { status: 400 });
289+
} catch (error) {
290+
const message = error instanceof Error ? error.message : 'Unknown error';
291+
return HttpResponse.json({ error: message }, { status: 400 });
282292
}
283293
}),
284294

@@ -287,11 +297,11 @@ export class MSWPlugin implements RuntimePlugin {
287297
try {
288298
const url = new URL(request.url);
289299
const viewType = url.searchParams.get('type') || 'list';
290-
// @ts-ignore
291-
const view = protocol.getUiView(params.object as string, viewType);
300+
const view = protocol.getUiView(params.object as string, viewType as 'list' | 'form');
292301
return HttpResponse.json(view);
293-
} catch (e: any) {
294-
return HttpResponse.json({ error: e.message }, { status: 404 });
302+
} catch (error) {
303+
const message = error instanceof Error ? error.message : 'Unknown error';
304+
return HttpResponse.json({ error: message }, { status: 404 });
295305
}
296306
}),
297307

0 commit comments

Comments
 (0)