Fix

Author: BlazOrazem

tests/support/MysqlCommandBuilderTest.php

@@ -5,80 +5,91 @@
 
 class MysqlCommandBuilderTest extends PluginTestCase
 {
-    protected array $config;
+    protected string $expectedUser;
+    protected string $expectedPass;
+    protected string $expectedDb;
+    protected string $expectedUsersTable;
+    protected string $expectedOrdersTable;
+    protected string $expectedDbTest;
+    protected string $expectedGzipOutput;
+    protected string $expectedPlainOutput;
 
     public function setUp(): void
     {
         parent::setUp();
 
-        $this->config = [
-            'username' => 'testuser',
-            'password' => 'secret',
-            'database' => 'mydb',
-        ];
+        if (PHP_OS_FAMILY === 'Windows') {
+            $this->expectedUser = '-u"testuser"';
+            $this->expectedPass = "-p'secret'";
+            $this->expectedDb = '"mydb"';
+            $this->expectedUsersTable = '"users"';
+            $this->expectedOrdersTable = '"orders"';
+            $this->expectedDbTest = '"mydbtest"';
+            $this->expectedGzipOutput = '| gzip > "/backups/db.sql.gz"';
+            $this->expectedPlainOutput = '> "/backups/db.sql"';
+        } else {
+            $this->expectedUser = "-u'testuser'";
+            $this->expectedPass = "-p'secret'";
+            $this->expectedDb = "'mydb'";
+            $this->expectedUsersTable = "'users'";
+            $this->expectedOrdersTable = "'orders'";
+            $this->expectedDbTest = "'mydbtest'";
+            $this->expectedGzipOutput = '| gzip > \'/backups/db.sql.gz\'';
+            $this->expectedPlainOutput = '> \'/backups/db.sql\'';
+        }
     }
 
-    /**
-     * Test function: dump
-     * Test building a basic dump command with gzip enabled.
-     */
     public function testDumpWithGzip(): void
     {
-        $command = MysqlCommandBuilder::dump($this->config, '/backups/db.sql.gz');
-
-        // Assert command contains mysqldump with correct credentials and database
-        $this->assertStringContainsString('mysqldump --skip-comments --replace -u"testuser" -p\'secret\' "mydb"', $command);
-
-        // Assert command includes gzip output redirection
-        $this->assertStringContainsString('| gzip > "/backups/db.sql.gz"', $command);
+        $config = ['username' => 'testuser', 'password' => 'secret', 'database' => 'mydb'];
+        $command = MysqlCommandBuilder::dump($config, '/backups/db.sql.gz', true);
+
+        $this->assertStringContainsString(
+            "mysqldump --skip-comments --replace {$this->expectedUser} {$this->expectedPass} {$this->expectedDb}",
+            $command
+        );
+        $this->assertStringContainsString($this->expectedGzipOutput, $command);
     }
 
-    /**
-     * Test function: dump
-     * Test building a dump command without gzip enabled.
-     */
     public function testDumpWithoutGzip(): void
     {
-        $command = MysqlCommandBuilder::dump($this->config, '/backups/db.sql', false);
-
-        // Assert command contains mysqldump with correct credentials and database
-        $this->assertStringContainsString('mysqldump --skip-comments --replace -u"testuser" -p\'secret\' "mydb"', $command);
-
-        // Assert command includes plain file output redirection
-        $this->assertStringContainsString('> "/backups/db.sql"', $command);
-
-        // Assert gzip is not included
-        $this->assertStringNotContainsString('gzip', $command);
+        $config = ['username' => 'testuser', 'password' => 'secret', 'database' => 'mydb'];
+        $command = MysqlCommandBuilder::dump($config, '/backups/db.sql', false);
+
+        $this->assertStringContainsString(
+            "mysqldump --skip-comments --replace {$this->expectedUser} {$this->expectedPass} {$this->expectedDb}",
+            $command
+        );
+        $this->assertStringContainsString($this->expectedPlainOutput, $command);
     }
 
-    /**
-     * Test function: dump
-     * Test building a dump command with limited tables.
-     */
     public function testDumpWithSpecificTables(): void
     {
-        $command = MysqlCommandBuilder::dump($this->config, '/backups/tables.sql', true, ['users', 'orders']);
+        $config = ['username' => 'testuser', 'password' => 'secret', 'database' => 'mydb'];
+        $tables = ['users', 'orders'];
+        $command = MysqlCommandBuilder::dump($config, '/backups/tables.sql', true, $tables);
+
+        $this->assertStringContainsString($this->expectedUsersTable, $command);
+        $this->assertStringContainsString($this->expectedOrdersTable, $command);
 
-        // Assert both tables are included and shell-escaped
-        $this->assertStringContainsString('"users"', $command);
-        $this->assertStringContainsString('"orders"', $command);
+        // Output path for gzip depends on platform
+        $expectedGzip = PHP_OS_FAMILY === 'Windows'
+            ? '| gzip > "/backups/tables.sql"'
+            : '| gzip > \'/backups/tables.sql\'';
+
+        $this->assertStringContainsString($expectedGzip, $command);
     }
 
-    /**
-     * Test function: import
-     * Test building an import command with normalized file path.
-     */
     public function testImportCommand(): void
     {
-        $command = MysqlCommandBuilder::import($this->config, 'C:\\backups\\db.sql.gz');
-
-        // Assert correct username and password
-        $this->assertStringContainsString('mysql -utestuser -psecret', $command);
+        $dbConfig = ['username' => 'testuser', 'password' => 'secret', 'database' => 'mydb'];
+        $command = MysqlCommandBuilder::import($dbConfig, 'C:\\backups\\db.sql.gz');
 
-        // Assert database name has 'test' suffix and is escaped with double quotes
-        $this->assertStringContainsString('"mydbtest"', $command);
+        $this->assertStringContainsString("-utestuser", $command);
+        $this->assertStringContainsString("-psecret", $command);
+        $this->assertStringContainsString($this->expectedDbTest, $command);
 
-        // Assert Windows path is normalized to forward slashes
-        $this->assertStringContainsString('C:/backups/db.sql.gz', $command);
+        // Path should always be normalized to forward slashes
+        $this->assertStringContainsString("C:/backups/db.sql.gz", $command);
     }
 }