All tests completed

Author: BlazOrazem

composer.json

@@ -18,10 +18,10 @@
         }
     ],
     "require": {
-        "php": "^8.0.2",
+        "php": "^8.1",
         "winter/storm": "^1.2",
         "phpseclib/phpseclib": "^3.0",
-        "composer/installers": "~1.0"
+        "composer/installers": "^2.2"
     },
     "autoload": {
         "psr-4": {
@@ -31,7 +31,8 @@
     "config": {
         "allow-plugins": {
             "composer/installers": true
-        }
+        },
+        "sort-packages": true
     },
     "extra": {
         "installer-name": "syncops",

support/MysqlCommandBuilder.php

@@ -9,7 +9,7 @@ public static function dump(array $config, string $outputFile, bool $gzip = true
         $db = escapeshellarg($config['database']);
         $limitTables = implode(' ', array_map('escapeshellarg', $tables));
 
-        $command = "mysqldump --skip-comments --replace -u{$user} -p{$pass} {$db} {$limitTables}";
+        $command = trim("mysqldump --skip-comments --replace -u{$user} -p{$pass} {$db} {$limitTables}");
 
         if ($gzip) {
             $command .= " | gzip > " . escapeshellarg($outputFile);

tests/HelpersTest.php

@@ -11,9 +11,7 @@ class HelpersTest extends PluginTestCase
     public function testFormatPathWithoutTrailingSlash(): void
     {
         $result = format_path('/var/www/html');
-
-        // Assert a trailing slash was added
-        $this->assertEquals('/var/www/html/', $result);
+        $this->assertSame('/var/www/html/', $result);
     }
 
     /**
@@ -23,9 +21,7 @@ public function testFormatPathWithoutTrailingSlash(): void
     public function testFormatPathWithTrailingSlash(): void
     {
         $result = format_path('/var/www/html/');
-
-        // Assert the path remains unchanged
-        $this->assertEquals('/var/www/html/', $result);
+        $this->assertSame('/var/www/html/', $result);
     }
 
     /**
@@ -35,9 +31,27 @@ public function testFormatPathWithTrailingSlash(): void
     public function testFormatPathWithMultipleTrailingSlashes(): void
     {
         $result = format_path('/var/www/html///');
+        $this->assertSame('/var/www/html/', $result);
+    }
 
-        // Assert only one trailing slash remains
-        $this->assertEquals('/var/www/html/', $result);
+    /**
+     * Test function: format_path
+     * Test formatting the root directory path.
+     */
+    public function testFormatPathWithRootSlash(): void
+    {
+        $result = format_path('/');
+        $this->assertSame('/', $result);
+    }
+
+    /**
+     * Test function: format_path
+     * Ensure Windows-style backslashes are not modified unexpectedly.
+     */
+    public function testFormatPathWithWindowsBackslashes(): void
+    {
+        $result = format_path('C:\\laragon\\www\\project');
+        $this->assertSame('C:\\laragon\\www\\project/', $result);
     }
 
     /**
@@ -47,8 +61,6 @@ public function testFormatPathWithMultipleTrailingSlashes(): void
     public function testFormatPathWithNull(): void
     {
         $result = format_path(null);
-
-        // Assert null is returned for null input
         $this->assertNull($result);
     }
 
@@ -59,8 +71,6 @@ public function testFormatPathWithNull(): void
     public function testFormatPathWithEmptyString(): void
     {
         $result = format_path('');
-
-        // Assert null is returned for empty string
         $this->assertNull($result);
     }
 }

tests/classes/RemoteExecutorTest.php

@@ -8,11 +8,6 @@
 
 class RemoteExecutorTest extends PluginTestCase
 {
-    public function setUp(): void
-    {
-        parent::setUp();
-    }
-
     public function tearDown(): void
     {
         Mockery::close();
@@ -21,22 +16,22 @@ public function tearDown(): void
 
     /**
      * Test function: __construct
-     * Test that constructor throws an exception when server config is empty.
+     * It should throw an exception when no config exists for the given server.
      */
     public function testConstructorThrowsIfNoConfig(): void
     {
         $this->expectException(\RuntimeException::class);
-        $this->expectExceptionMessage("No config for server invalid_server");
+        $this->expectExceptionMessage('No config for server invalid_server');
 
-        // Provide empty array to satisfy typed property
-        config()->set("syncops.connections.invalid_server", []);
+        // Use empty array (null would cause TypeError before our check)
+        config()->set('syncops.connections.invalid_server', []);
 
         new RemoteExecutor('invalid_server');
     }
 
     /**
      * Test function: __construct
-     * Test that SSH and SFTP executors are created with password credentials.
+     * When password credentials are provided, they should be used directly.
      */
     public function testConstructorWithPassword(): void
     {
@@ -50,12 +45,9 @@ public function testConstructorWithPassword(): void
             'key_path' => '',
         ]);
 
-        // Mock executors to avoid real connections
-        $sshMock = Mockery::mock(SshExecutor::class)->makePartial();
-        $sftpMock = Mockery::mock(SftpExecutor::class)->makePartial();
-
-        $this->app->bind(SshExecutor::class, fn() => $sshMock);
-        $this->app->bind(SftpExecutor::class, fn() => $sftpMock);
+        // Mock PublicKeyLoader to ensure it's not used
+        $mockKeyLoader = Mockery::mock('alias:phpseclib3\Crypt\PublicKeyLoader');
+        $mockKeyLoader->shouldNotReceive('load');
 
         $executor = new RemoteExecutor($server);
 
@@ -65,7 +57,7 @@ public function testConstructorWithPassword(): void
 
     /**
      * Test function: __construct
-     * Test that SSH and SFTP executors are created with public key credentials.
+     * When key_path is set, PublicKeyLoader::load() should be called.
      */
     public function testConstructorWithPublicKey(): void
     {
@@ -80,27 +72,23 @@ public function testConstructorWithPublicKey(): void
             'key_path' => $keyPath,
         ]);
 
-        // Mock PublicKeyLoader
         $mockKeyLoader = Mockery::mock('alias:phpseclib3\Crypt\PublicKeyLoader');
-        $mockKeyLoader->shouldReceive('load')->once()->andReturn('PUBLIC_KEY');
-
-        $sshMock = Mockery::mock(SshExecutor::class)->makePartial();
-        $sftpMock = Mockery::mock(SftpExecutor::class)->makePartial();
-
-        $this->app->bind(SshExecutor::class, fn() => $sshMock);
-        $this->app->bind(SftpExecutor::class, fn() => $sftpMock);
+        $mockKeyLoader->shouldReceive('load')
+            ->once()
+            ->with('FAKE_KEY')
+            ->andReturn('PUBLIC_KEY');
 
         $executor = new RemoteExecutor($server);
 
         $this->assertInstanceOf(SshExecutor::class, $executor->ssh);
         $this->assertInstanceOf(SftpExecutor::class, $executor->sftp);
 
-        unlink($keyPath);
+        @unlink($keyPath);
     }
 
     /**
      * Test function: connectBoth
-     * Test that connectBoth() calls connect() on both SSH and SFTP executors.
+     * It should call connect() on both SSH and SFTP executors.
      */
     public function testConnectBoth(): void
     {
@@ -116,18 +104,23 @@ public function testConnectBoth(): void
 
         $executor->connectBoth();
 
-        // PHPUnit requires at least one assertion
-        $this->assertTrue(true);
+        // Verify that both connect() calls occurred
+        $sshMock->shouldHaveReceived('connect')->once();
+        $sftpMock->shouldHaveReceived('connect')->once();
+
+        // Add an explicit PHPUnit assertion to avoid "risky" flag
+        $this->assertTrue(true, 'Mock expectations verified successfully.');
     }
 }
 
 /**
- * Helper class to bypass RemoteExecutor constructor for connectBoth test.
+ * Helper class that bypasses RemoteExecutor's constructor
+ * so we can manually inject mock executors.
  */
 class RemoteExecutorTestHelper extends RemoteExecutor
 {
     public function __construct()
     {
-        // Bypass parent constructor
+        // Skip parent constructor
     }
 }