From 2d1a8f3f12d72ab4510c0b3b69607324f2657b48 Mon Sep 17 00:00:00 2001 From: khabzox <152230716+khabzox@users.noreply.github.com> Date: Mon, 23 Jun 2025 18:52:13 +0100 Subject: [PATCH] clean: Remove non-technical variants from Node.js logo component Remove pride flag variant from logo component - this is a runtime environment, not appropriate place for political/social expressions. Technical changes: - Set logoVariant to 'default' in site configuration - Remove 'pride' from LogoVariant TypeScript type - Remove pride variant from NodejsLogo Storybook stories - Remove pride-specific rendering logic from component - Update design system stories Keep the logo component focused on technical branding only. Note: If you want to add social/political variants again, please create a separate discussion/issue first to establish clear guidelines about what belongs in technical infrastructure vs. community spaces. --- .../public/static/logos/nodejsDarkPride.svg | 1 - .../public/static/logos/nodejsLightPride.svg | 1 - apps/site/site.json | 2 +- apps/site/types/config.ts | 2 +- .../Common/NodejsLogo/index.stories.tsx | 4 - packages/ui-components/Icons/Logos/Nodejs.tsx | 350 +++--------------- .../__design__/node-logos.stories.tsx | 4 - packages/ui-components/types.ts | 2 +- 8 files changed, 57 insertions(+), 309 deletions(-) delete mode 100644 apps/site/public/static/logos/nodejsDarkPride.svg delete mode 100644 apps/site/public/static/logos/nodejsLightPride.svg diff --git a/apps/site/public/static/logos/nodejsDarkPride.svg b/apps/site/public/static/logos/nodejsDarkPride.svg deleted file mode 100644 index b6d0c77f854f3..0000000000000 --- a/apps/site/public/static/logos/nodejsDarkPride.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/apps/site/public/static/logos/nodejsLightPride.svg b/apps/site/public/static/logos/nodejsLightPride.svg deleted file mode 100644 index 9de9a30fa9e23..0000000000000 --- a/apps/site/public/static/logos/nodejsLightPride.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/apps/site/site.json b/apps/site/site.json index 6da498a337cd1..1b5eed62a744f 100644 --- a/apps/site/site.json +++ b/apps/site/site.json @@ -3,7 +3,7 @@ "description": "Node.js® is a free, open-source, cross-platform JavaScript runtime environment that lets developers create servers, web apps, command line tools and scripts.", "favicon": "/static/images/favicons/favicon.png", "accentColor": "#333", - "logoVariant": "pride", + "logoVariant": "default", "twitter": { "username": "@nodejs", "card": "summary", diff --git a/apps/site/types/config.ts b/apps/site/types/config.ts index f307d15457aab..3601fb94c2608 100644 --- a/apps/site/types/config.ts +++ b/apps/site/types/config.ts @@ -13,7 +13,7 @@ export interface OGConfig { imgHeight: string; } -export type LogoVariant = 'default' | 'pride'; +export type LogoVariant = 'default'; export interface SiteConfig { title: string; diff --git a/packages/ui-components/Common/NodejsLogo/index.stories.tsx b/packages/ui-components/Common/NodejsLogo/index.stories.tsx index acaa659efbae6..f13cf397d2d82 100644 --- a/packages/ui-components/Common/NodejsLogo/index.stories.tsx +++ b/packages/ui-components/Common/NodejsLogo/index.stories.tsx @@ -7,8 +7,4 @@ type Meta = MetaObj; export const Default: Story = {}; -export const WithPride: Story = { - args: { variant: 'pride' }, -}; - export default { component: NodejsLogo } as Meta; diff --git a/packages/ui-components/Icons/Logos/Nodejs.tsx b/packages/ui-components/Icons/Logos/Nodejs.tsx index d6129d77d73a5..76367ac614f79 100644 --- a/packages/ui-components/Icons/Logos/Nodejs.tsx +++ b/packages/ui-components/Icons/Logos/Nodejs.tsx @@ -1,16 +1,12 @@ import classNames from 'classnames'; import type { FC, SVGProps } from 'react'; -import type { LogoVariant } from '#ui/types'; - type NodeJsLogoProps = SVGProps & { - variant?: LogoVariant; ariaLabel?: string; }; const NodejsIcon: FC = ({ className, - variant = 'default', ariaLabel = '', ...props }) => { @@ -71,300 +67,62 @@ const NodejsIcon: FC = ({ fill="#5FA04E" /> - {variant === 'pride' ? ( - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ) : ( - <> - - - - - )} + + + - {variant === 'pride' ? ( - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ) : ( - - - - - - - - - - - - - - - - - - - - - - )} + + + + + + + + + + + + + + + + + + + + + ); }; diff --git a/packages/ui-components/__design__/node-logos.stories.tsx b/packages/ui-components/__design__/node-logos.stories.tsx index 543538c03f6cc..29c9224b0dc65 100644 --- a/packages/ui-components/__design__/node-logos.stories.tsx +++ b/packages/ui-components/__design__/node-logos.stories.tsx @@ -14,10 +14,6 @@ export const HorizontalLogo: StoryObj = { render: () => , }; -export const PrideLogo: StoryObj = { - render: () => , -}; - export const StackedLogos: StoryObj = { render: () => (
diff --git a/packages/ui-components/types.ts b/packages/ui-components/types.ts index 86088827f76e8..2e1a5859ca350 100644 --- a/packages/ui-components/types.ts +++ b/packages/ui-components/types.ts @@ -6,7 +6,7 @@ import type { ReactNode, } from 'react'; -export type LogoVariant = 'default' | 'pride'; +export type LogoVariant = 'default'; export type TailwindSVG = SVGProps & { tw?: string }; export type BlogPreviewType = 'announcements' | 'release' | 'vulnerability'; export type LinkLike =