repair

Author: mertcanaltin

src/node_sqlite.cc

@@ -201,14 +201,14 @@ static constexpr std::array<LimitInfo, 11> kLimitMapping = {{
     {"triggerDepth", SQLITE_LIMIT_TRIGGER_DEPTH, SQLITE_MAX_TRIGGER_DEPTH},
 }};
 
-// Helper function to find limit index from JS property name
-static constexpr int GetLimitIndexFromName(std::string_view name) {
-  for (size_t i = 0; i < kLimitMapping.size(); ++i) {
-    if (name == kLimitMapping[i].js_name) {
-      return static_cast<int>(i);
+// Helper function to find limit info from JS property name
+static constexpr const LimitInfo* GetLimitInfoFromName(std::string_view name) {
+  for (const auto& info : kLimitMapping) {
+    if (name == info.js_name) {
+      return &info;
     }
   }
-  return -1;  // Not found
+  return nullptr;
 }
 
 inline MaybeLocal<Object> CreateSQLiteError(Isolate* isolate,
@@ -792,9 +792,9 @@ Intercepted DatabaseSyncLimits::LimitsGetter(
   Isolate* isolate = env->isolate();
 
   Utf8Value prop_name(isolate, property);
-  int idx = GetLimitIndexFromName(prop_name.ToStringView());
+  const LimitInfo* limit_info = GetLimitInfoFromName(prop_name.ToStringView());
 
-  if (idx < 0) {
+  if (!limit_info) {
     return Intercepted::kNo;  // Unknown property, let default handling occur
   }
 
@@ -804,7 +804,7 @@ Intercepted DatabaseSyncLimits::LimitsGetter(
   }
 
   int current_value = sqlite3_limit(
-      limits->database_->Connection(), kLimitMapping[idx].sqlite_limit_id, -1);
+      limits->database_->Connection(), limit_info->sqlite_limit_id, -1);
   info.GetReturnValue().Set(Integer::New(isolate, current_value));
   return Intercepted::kYes;
 }
@@ -824,9 +824,9 @@ Intercepted DatabaseSyncLimits::LimitsSetter(
   Isolate* isolate = env->isolate();
 
   Utf8Value prop_name(isolate, property);
-  int idx = GetLimitIndexFromName(*prop_name);
+  const LimitInfo* limit_info = GetLimitInfoFromName(*prop_name);
 
-  if (idx < 0) {
+  if (!limit_info) {
     return Intercepted::kNo;
   }
 
@@ -849,15 +849,14 @@ Intercepted DatabaseSyncLimits::LimitsSetter(
   }
 
   // Validate against compile-time maximum
-  if (new_value > kLimitMapping[idx].max_value) {
+  if (new_value > limit_info->max_value) {
     THROW_ERR_OUT_OF_RANGE(isolate,
                            "Limit value exceeds compile-time maximum.");
     return Intercepted::kYes;
   }
 
-  sqlite3_limit(limits->database_->Connection(),
-                kLimitMapping[idx].sqlite_limit_id,
-                new_value);
+  sqlite3_limit(
+      limits->database_->Connection(), limit_info->sqlite_limit_id, new_value);
   return Intercepted::kYes;
 }
 
@@ -869,9 +868,9 @@ Intercepted DatabaseSyncLimits::LimitsQuery(
 
   Isolate* isolate = info.GetIsolate();
   Utf8Value prop_name(isolate, property);
-  int idx = GetLimitIndexFromName(prop_name.ToStringView());
+  const LimitInfo* limit_info = GetLimitInfoFromName(prop_name.ToStringView());
 
-  if (idx < 0) {
+  if (!limit_info) {
     return Intercepted::kNo;
   }