Skip to content

Commit f3d3968

Browse files
aduh95ruyadorno
authored andcommitted
Revert "build: add temporal test on GHA windows"
This reverts commit 8d83d80. PR-URL: #61810
1 parent 6a2c8d8 commit f3d3968

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

.github/workflows/coverage-windows.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,10 @@ jobs:
7979
allow-prereleases: true
8080
- name: Install deps
8181
run: choco install nasm
82-
- name: Install Rust ${{ env.RUSTC_VERSION }}
83-
run: |
84-
rustup override set "$RUSTC_VERSION"
85-
rustup --version
8682
- name: Environment Information
8783
run: npx envinfo
8884
- name: Build
89-
run: ./vcbuild.bat clang-cl v8temporal
85+
run: ./vcbuild.bat clang-cl
9086
# TODO(bcoe): investigate tests that fail with coverage enabled
9187
# on Windows.
9288
- name: Test

vcbuild.bat

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ set doc=
7272
set extra_msbuild_args=
7373
set compile_commands=
7474
set cfg=
75-
set v8temporal=
7675
set v8windbg=
7776
set exit_code=0
7877

@@ -98,7 +97,6 @@ if /i "%1"=="sign" set sign=1&goto arg-ok
9897
if /i "%1"=="nosnapshot" set nosnapshot=1&goto arg-ok
9998
if /i "%1"=="nonpm" set nonpm=1&goto arg-ok
10099
if /i "%1"=="ltcg" set ltcg=1&goto arg-ok
101-
if /i "%1"=="v8temporal" set v8temporal=1&goto arg-ok
102100
if /i "%1"=="v8windbg" set v8windbg=1&goto arg-ok
103101
if /i "%1"=="licensertf" set licensertf=1&goto arg-ok
104102
if /i "%1"=="test" set test_args=%test_args% %common_test_suites%&set lint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok
@@ -216,7 +214,6 @@ if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose
216214
if defined ccache_path set configure_flags=%configure_flags% --use-ccache-win
217215
if defined compile_commands set configure_flags=%configure_flags% -C
218216
if defined cfg set configure_flags=%configure_flags% --control-flow-guard
219-
if defined v8temporal set configure_flags=%configure_flags% --v8-enable-temporal-support
220217
if defined v8windbg set configure_flags=%configure_flags% --enable-v8windbg
221218

222219
if "%target_arch%"=="x86" (

0 commit comments

Comments
 (0)