Skip to content

Commit c755b01

Browse files
authored
stream: move _stream_* to end-of-life
PR-URL: #60657 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent e9b0849 commit c755b01

18 files changed

+8
-131
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929

3030
# streams
3131

32-
/lib/_stream* @nodejs/streams
3332
/lib/internal/streams/* @nodejs/streams
3433
/lib/stream.js @nodejs/streams
3534
/lib/stream/* @nodejs/streams

doc/api/deprecations.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2812,12 +2812,15 @@ This property is a reference to the instance itself.
28122812

28132813
<!-- YAML
28142814
changes:
2815+
- version: REPLACEME
2816+
pr-url: https://github.com/nodejs/node/pull/60657
2817+
description: End-of-Life.
28152818
- version: v12.0.0
28162819
pr-url: https://github.com/nodejs/node/pull/26245
28172820
description: Runtime deprecation.
28182821
-->
28192822

2820-
Type: Runtime
2823+
Type: End-of-Life
28212824

28222825
The `node:_stream_wrap` module is deprecated.
28232826

@@ -4199,6 +4202,9 @@ an internal nodejs implementation rather than a public facing API, use `node:tls
41994202

42004203
<!-- YAML
42014204
changes:
4205+
- version: REPLACEME
4206+
pr-url: https://github.com/nodejs/node/pull/60657
4207+
description: End-of-Life.
42024208
- version:
42034209
- v24.2.0
42044210
- v22.17.0
@@ -4207,7 +4213,7 @@ changes:
42074213
description: Runtime deprecation.
42084214
-->
42094215

4210-
Type: Runtime
4216+
Type: End-of-Life
42114217

42124218
The `node:_stream_duplex`, `node:_stream_passthrough`, `node:_stream_readable`, `node:_stream_transform`,
42134219
`node:_stream_wrap` and `node:_stream_writable` modules are deprecated as they should be considered

lib/_stream_duplex.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

lib/_stream_passthrough.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

lib/_stream_readable.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

lib/_stream_transform.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

lib/_stream_wrap.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

lib/_stream_writable.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

lib/internal/main/mksnapshot.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,6 @@ const supportedModules = new SafeSet(new SafeArrayIterator([
4242
// '_http_incoming',
4343
// '_http_outgoing',
4444
// '_http_server',
45-
'_stream_duplex',
46-
'_stream_passthrough',
47-
'_stream_readable',
48-
'_stream_transform',
49-
'_stream_wrap',
50-
'_stream_writable',
5145
// '_tls_common',
5246
// '_tls_wrap',
5347
'assert',

test/parallel/test-internal-module-require.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,6 @@ const expectedPublicModules = new Set([
2424
'_http_incoming',
2525
'_http_outgoing',
2626
'_http_server',
27-
'_stream_duplex',
28-
'_stream_passthrough',
29-
'_stream_readable',
30-
'_stream_transform',
31-
'_stream_wrap',
32-
'_stream_writable',
3327
'_tls_common',
3428
'_tls_wrap',
3529
'assert',

0 commit comments

Comments
 (0)