build: enable -DV8_ENABLE_CHECKS flag

Fixes: #61301

Author: islandryu

configure.py

@@ -1481,6 +1481,15 @@ def set_configuration_variable(configs, name, release=None, debug=None):
   configs['Release']['variables'][name] = release
   configs['Debug']['variables'][name] = debug
 
+def set_configuration_variable_and_defines(configs, name, define, release=None, debug=None):
+  set_configuration_variable(configs, name, release, debug)
+  if configs['Debug'].get('defines') is None:
+      configs['Debug']['defines'] = []
+  if configs['Release'].get('defines') is None:
+      configs['Release']['defines'] = []
+  configs['Debug']['defines'].append(define)
+  configs['Release']['defines'].append(define)
+
 def configure_arm(o):
   if options.arm_float_abi:
     arm_float_abi = options.arm_float_abi
@@ -1817,8 +1826,14 @@ def configure_rust(o, configs):
 
 
 def configure_v8(o, configs):
-  set_configuration_variable(configs, 'v8_enable_v8_checks', release=1, debug=0)
-
+  set_configuration_variable_and_defines(
+      configs,
+      'v8_enable_v8_checks',
+      'V8_ENABLE_CHECKS',
+      release='0',
+      debug='1'
+  )
+ 
   o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1
   o['variables']['v8_enable_javascript_promise_hooks'] = 1
   o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0

lib/util.js

@@ -456,6 +456,8 @@ function getCallSites(frameCount = 10, options) {
   if (options.sourceMap === true || (getOptionValue('--enable-source-maps') && options.sourceMap !== false)) {
     return mapCallSite(binding.getCallSites(frameCount));
   }
+
+  frameCount = Math.floor(frameCount);
   return binding.getCallSites(frameCount);
 };
 

src/heap_utils.cc

@@ -89,7 +89,7 @@ class JSGraph : public EmbedderGraph {
   }
 
   Node* V8Node(const Local<v8::Value>& value) override {
-    return V8Node(value.As<v8::Data>());
+    return V8Node(v8::Local<v8::Data>(value));
   }
 
   Node* AddNode(std::unique_ptr<Node> node) override {

src/node_builtins.cc

@@ -9,6 +9,7 @@
 #include "quic/guard.h"
 #include "simdutf.h"
 #include "util-inl.h"
+#include "v8-value.h"
 
 namespace node {
 namespace builtins {
@@ -441,7 +442,7 @@ void BuiltinLoader::SaveCodeCache(const std::string& id, Local<Data> data) {
     new_cached_data.reset(
         ScriptCompiler::CreateCodeCache(mod->GetUnboundModuleScript()));
   } else {
-    Local<Function> fun = data.As<Function>();
+    Local<Function> fun = data.As<Value>().As<Function>();
     new_cached_data.reset(ScriptCompiler::CreateCodeCacheForFunction(fun));
   }
   CHECK_NOT_NULL(new_cached_data);

src/node_util.cc

@@ -258,7 +258,7 @@ static void GetCallSites(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(context);
 
   CHECK_EQ(args.Length(), 1);
-  CHECK(args[0]->IsNumber());
+  CHECK(args[0]->IsUint32());
   const uint32_t frames = args[0].As<Uint32>()->Value();
   CHECK(frames >= 1 && frames <= 200);
 

src/util-inl.h

@@ -22,6 +22,7 @@
 #ifndef SRC_UTIL_INL_H_
 #define SRC_UTIL_INL_H_
 
+#include "v8-isolate.h"
 #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
 
 #include <cmath>
@@ -678,10 +679,15 @@ T FromV8Value(v8::Local<v8::Value> value) {
         "Type is out of unsigned integer range");
     if constexpr (!loose) {
       CHECK(value->IsUint32());
+      return static_cast<T>(value.As<v8::Uint32>()->Value());
     } else {
       CHECK(value->IsNumber());
+      v8::Isolate* isolate = v8::Isolate::GetCurrent();
+      v8::Local<v8::Context> context = isolate->GetCurrentContext();
+      v8::Maybe<uint32_t> maybe = value->Uint32Value(context);
+      CHECK(!maybe.IsNothing());
+      return static_cast<T>(maybe.FromJust());
     }
-    return static_cast<T>(value.As<v8::Uint32>()->Value());
   } else if constexpr (std::is_integral_v<T> && std::is_signed_v<T>) {
     static_assert(
         std::numeric_limits<T>::max() <= std::numeric_limits<int32_t>::max() &&