fixup! stream: readable read one buffer at a time

Author: ronag

test/parallel/test-crypto-cipheriv-decipheriv.js

@@ -31,11 +31,11 @@ function testCipher1(key, iv) {
   // quite small, so there's no harm.
   const cStream = crypto.createCipheriv('des-ede3-cbc', key, iv);
   cStream.end(plaintext);
-  ciph = cStream.read();
+  ciph = cStream.read(cStream.readableLength);
 
   const dStream = crypto.createDecipheriv('des-ede3-cbc', key, iv);
   dStream.end(ciph);
-  txt = dStream.read().toString('utf8');
+  txt = dStream.read(dStream.readableLength).toString('utf8');
 
   assert.strictEqual(txt, plaintext,
                      `streaming cipher with key ${key} and iv ${iv}`);

test/parallel/test-stream-readable-infinite-read.js

@@ -22,12 +22,12 @@ readable.on('readable', common.mustCall(function() {
     return;
   }
 
-  const data = readable.read();
+  const data =  readable.read(readable.readableLength);
   // TODO(mcollina): there is something odd in the highWaterMark logic
   // investigate.
   if (i === 1) {
-    assert.strictEqual(data.length, 8192);
+    assert.strictEqual(data.length, 8192 * 2);
   } else {
-    assert.strictEqual(data.length, 8192);
+    assert.strictEqual(data.length, 8192 * 2);
   }
 }, 11));

test/parallel/test-stream-readable-needReadable.js

@@ -32,7 +32,7 @@ const asyncReadable = new Readable({
 });
 
 asyncReadable.on('readable', common.mustCall(() => {
-  if (asyncReadable.read() !== null) {
+  if (asyncReadable.read(asyncReadable.readableLength) !== null) {
     // After each read(), the buffer is empty.
     // If the stream doesn't end now,
     // then we need to notify the reader on future changes.

test/parallel/test-webstreams-pipeline.js

@@ -126,7 +126,7 @@ const http = require('http');
   });
 
   pipeline(r, ws, common.mustSucceed(() => {
-    assert.deepStrictEqual(values, ['helloworld']);
+    assert.deepStrictEqual(values, ['hello', 'world']);
   }));
 
   r.push('hello');
@@ -181,7 +181,7 @@ const http = require('http');
   });
 
   pipeline(rs, t, ws, common.mustSucceed(() => {
-    assert.deepStrictEqual(values, ['HELLOWORLD']);
+    assert.deepStrictEqual(values, ['HELLO', 'WORLD']);
   }));
 
   c.enqueue('hello');

test/parallel/test-zlib-flush-write-sync-interleaved.js

@@ -19,7 +19,7 @@ for (const chunk of ['abc', 'def', 'ghi']) {
   compress.write(chunk, common.mustCall(() => events.push({ written: chunk })));
   compress.flush(Z_PARTIAL_FLUSH, common.mustCall(() => {
     events.push('flushed');
-    const chunk = compress.read();
+    const chunk = compress.read(compress.readableLength);
     if (chunk !== null)
       compressedChunks.push(chunk);
   }));
@@ -36,7 +36,7 @@ function writeToDecompress() {
   const chunk = compressedChunks.shift();
   if (chunk === undefined) return decompress.end();
   decompress.write(chunk, common.mustCall(() => {
-    events.push({ read: decompress.read() });
+    events.push({ read: decompress.read(decompress.readableLength) });
     writeToDecompress();
   }));
 }