Skip to content

Commit 61bfdb3

Browse files
committed
fs: fix ENOTDIR in globSync when file is treated as dir
`fs.globSync` failed with `ENOTDIR` when a path component in a glob pattern was a file but used as a directory (e.g., 'foo{,/bar}' when 'foo' is a file). This change aligns `getDirentSync` with the asynchronous `getDirent` by wrapping the `lstatSync` call in a `try-catch` block to safely return `null` on such errors. Fixes: #61257
1 parent 95852d7 commit 61bfdb3

File tree

2 files changed

+26
-4
lines changed

2 files changed

+26
-4
lines changed

lib/internal/fs/glob.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,15 @@ async function getDirent(path) {
6565
* @returns {DirentFromStats|null}
6666
*/
6767
function getDirentSync(path) {
68-
const stat = lstatSync(path, { throwIfNoEntry: false });
69-
if (stat === undefined) {
68+
try {
69+
const stat = lstatSync(path, { throwIfNoEntry: false });
70+
if (stat === undefined) {
71+
return null;
72+
}
73+
return new DirentFromStats(basename(path), stat, dirname(path));
74+
} catch {
7075
return null;
7176
}
72-
return new DirentFromStats(basename(path), stat, dirname(path));
7377
}
7478

7579
/**

test/parallel/test-fs-glob.mjs

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as common from '../common/index.mjs';
22
import tmpdir from '../common/tmpdir.js';
33
import { resolve, dirname, sep, relative, join, isAbsolute } from 'node:path';
44
import { mkdir, writeFile, symlink, glob as asyncGlob } from 'node:fs/promises';
5-
import { glob, globSync, Dirent, chmodSync } from 'node:fs';
5+
import { glob, globSync, Dirent, chmodSync, writeFileSync, rmSync } from 'node:fs';
66
import { test, describe } from 'node:test';
77
import { pathToFileURL } from 'node:url';
88
import { promisify } from 'node:util';
@@ -543,3 +543,21 @@ describe('glob - with restricted directory', function() {
543543
}
544544
});
545545
});
546+
547+
describe('globSync - ENOTDIR', function() {
548+
test('should return empty array when a file is treated as a directory', () => {
549+
const file = tmpdir.resolve('foo');
550+
writeFileSync(file, '');
551+
try {
552+
const pattern = 'foo{,/bar}';
553+
const actual = globSync(pattern, { cwd: tmpdir.path }).sort();
554+
assert.deepStrictEqual(actual, ['foo']);
555+
} finally {
556+
try {
557+
rmSync(file);
558+
} catch {
559+
// ignore
560+
}
561+
}
562+
});
563+
});

0 commit comments

Comments
 (0)