src: use node- prefix on thread names

Author: sxa

src/inspector_agent.cc

@@ -84,7 +84,7 @@ static void StartIoThreadWakeup(int signo, siginfo_t* info, void* ucontext) {
 }
 
 inline void* StartIoThreadMain(void* unused) {
-  uv_thread_setname("SignalInspector");
+  uv_thread_setname("node-SignalInspector");
   for (;;) {
     uv_sem_wait(&start_io_thread_semaphore);
     Mutex::ScopedLock lock(start_io_thread_async_mutex);

src/inspector_io.cc

@@ -286,7 +286,7 @@ void InspectorIo::ThreadMain(void* io) {
 }
 
 void InspectorIo::ThreadMain() {
-  int thread_name_error = uv_thread_setname("InspectorIo");
+  int thread_name_error = uv_thread_setname("node-InspectorIo");
   if (!thread_name_error) [[unlikely]] {
     per_process::Debug(node::DebugCategory::INSPECTOR_SERVER,
                        "Failed to set thread name for Inspector\n");

src/node.cc

@@ -1234,7 +1234,7 @@ InitializeOncePerProcessInternal(const std::vector<std::string>& args,
   }
 
   if (!(flags & ProcessInitializationFlags::kNoInitializeNodeV8Platform)) {
-    uv_thread_setname("MainThread");
+    uv_thread_setname("node-MainThread");
     per_process::v8_platform.Initialize(
         static_cast<int>(per_process::cli_options->v8_thread_pool_size));
     result->platform_ = per_process::v8_platform.Platform();

src/node_platform.cc

@@ -49,7 +49,7 @@ static void PrintSourceLocation(const v8::SourceLocation& location) {
 }
 
 static void PlatformWorkerThread(void* data) {
-  uv_thread_setname("V8Worker");
+  uv_thread_setname("node-V8Worker");
   std::unique_ptr<PlatformWorkerData>
       worker_data(static_cast<PlatformWorkerData*>(data));
 
@@ -101,7 +101,7 @@ class WorkerThreadsTaskRunner::DelayedTaskScheduler {
 
   std::unique_ptr<uv_thread_t> Start() {
     auto start_thread = [](void* data) {
-      uv_thread_setname("DelayedTaskSchedulerWorker");
+      uv_thread_setname("node-DelayedTaskSchedulerWorker");
       static_cast<DelayedTaskScheduler*>(data)->Run();
     };
     std::unique_ptr<uv_thread_t> t { new uv_thread_t() };

src/node_watchdog.cc

@@ -80,7 +80,7 @@ Watchdog::~Watchdog() {
 
 
 void Watchdog::Run(void* arg) {
-  uv_thread_setname("Watchdog");
+  uv_thread_setname("node-Watchdog");
   Watchdog* wd = static_cast<Watchdog*>(arg);
 
   // UV_RUN_DEFAULT the loop will be stopped either by the async or the
@@ -230,7 +230,7 @@ void TraceSigintWatchdog::HandleInterrupt() {
 
 #ifdef __POSIX__
 void* SigintWatchdogHelper::RunSigintWatchdog(void* arg) {
-  uv_thread_setname("SigintWatchdog");
+  uv_thread_setname("node-SigintWatchdog");
   // Inside the helper thread.
   bool is_stopping;
   do {

src/tracing/agent.cc

@@ -98,7 +98,7 @@ void Agent::Start() {
            uv_thread_create(
                &thread_,
                [](void* arg) {
-                 uv_thread_setname("TraceEventWorker");
+                 uv_thread_setname("node-TraceEventWorker");
                  Agent* agent = static_cast<Agent*>(arg);
                  uv_run(&agent->tracing_loop_, UV_RUN_DEFAULT);
                },

test/addons/uv-thread-name/test.js

@@ -12,11 +12,11 @@ const bindingPath = require.resolve(`./build/${common.buildType}/binding`);
 const binding = require(bindingPath);
 
 if (isMainThread) {
-  assert.strictEqual(binding.getThreadName(), 'MainThread');
+  assert.strictEqual(binding.getThreadName(), 'node-MainThread');
 
   const worker = new Worker(__filename);
   worker.on('message', common.mustCall((data) => {
-    assert.strictEqual(data, 'WorkerThread');
+    assert.strictEqual(data, 'node-WorkerThread');
   }));
   worker.on('error', common.mustNotCall());
   worker.on('exit', common.mustCall((code) => {