Skip to content

Commit 20a0eed

Browse files
committed
sqlite: remove redundant parameter
1 parent 7c71345 commit 20a0eed

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/node_sqlite.cc

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -831,8 +831,8 @@ void DatabaseSync::CreateTagStore(const FunctionCallbackInfo<Value>& args) {
831831
capacity = args[0].As<Number>()->Value();
832832
}
833833

834-
BaseObjectPtr<SQLTagStore> session = SQLTagStore::Create(
835-
env, BaseObjectWeakPtr<DatabaseSync>(db), args.This(), capacity);
834+
BaseObjectPtr<SQLTagStore> session =
835+
SQLTagStore::Create(env, BaseObjectWeakPtr<DatabaseSync>(db), capacity);
836836
if (!session) {
837837
// Handle error if creation failed
838838
THROW_ERR_SQLITE_ERROR(env->isolate(), "Failed to create SQLTagStore");
@@ -2710,18 +2710,15 @@ Local<FunctionTemplate> SQLTagStore::GetConstructorTemplate(Environment* env) {
27102710
}
27112711

27122712
BaseObjectPtr<SQLTagStore> SQLTagStore::Create(
2713-
Environment* env,
2714-
BaseObjectWeakPtr<DatabaseSync> database,
2715-
Local<Object> database_object,
2716-
int capacity) {
2713+
Environment* env, BaseObjectWeakPtr<DatabaseSync> database, int capacity) {
27172714
Local<Object> obj;
27182715
if (!GetConstructorTemplate(env)
27192716
->InstanceTemplate()
27202717
->NewInstance(env->context())
27212718
.ToLocal(&obj)) {
27222719
return nullptr;
27232720
}
2724-
obj->SetInternalField(kDatabaseObject, database_object);
2721+
obj->SetInternalField(kDatabaseObject, database->object());
27252722
return MakeBaseObject<SQLTagStore>(env, obj, std::move(database), capacity);
27262723
}
27272724

src/node_sqlite.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -315,10 +315,7 @@ class SQLTagStore : public BaseObject {
315315
int capacity);
316316
~SQLTagStore() override;
317317
static BaseObjectPtr<SQLTagStore> Create(
318-
Environment* env,
319-
BaseObjectWeakPtr<DatabaseSync> database,
320-
v8::Local<v8::Object> database_object,
321-
int capacity);
318+
Environment* env, BaseObjectWeakPtr<DatabaseSync> database, int capacity);
322319
static v8::Local<v8::FunctionTemplate> GetConstructorTemplate(
323320
Environment* env);
324321
static void All(const v8::FunctionCallbackInfo<v8::Value>& args);

0 commit comments

Comments
 (0)