sqlite: make custom function to throw when in async mode

Author: geeksilva97

src/node_sqlite.cc

@@ -1256,12 +1256,12 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
   int r = sqlite3_prepare_v2(db->connection_, *sql, -1, &s, 0);
   CHECK_ERROR_OR_THROW(env->isolate(), db, r, SQLITE_OK, void());
 
-  if (db->has_custom_func) {
-    db->has_custom_func = false;
-  }
+  bool stmt_has_custom_func = db->has_custom_func;
+  db->has_custom_func = false;
 
   BaseObjectPtr<Statement> stmt =
       Statement::Create(env, BaseObjectPtr<Database>(db), s);
+  stmt->has_custom_functions_ = stmt_has_custom_func;
   db->statements_.insert(stmt.get());
   args.GetReturnValue().Set(stmt->object());
 }
@@ -1478,7 +1478,6 @@ void Database::CustomFunction(const FunctionCallbackInfo<Value>& args) {
                                      nullptr,
                                      UserDefinedFunction::xDestroy);
   CHECK_ERROR_OR_THROW(env->isolate(), db, r, SQLITE_OK, void());
-  // calls void Database::AddCustomFunction(const std::string& name) {
   db->AddCustomFunction(*name);
 }
 
@@ -2197,6 +2196,7 @@ Statement::Statement(Environment* env,
     : BaseObject(env, object), db_(std::move(db)) {
   MakeWeak();
   statement_ = stmt;
+  has_custom_functions_ = false;
   use_big_ints_ = db_->use_big_ints();
   return_arrays_ = db_->return_arrays();
   allow_bare_named_params_ = db_->allow_bare_named_params();
@@ -2884,6 +2884,11 @@ void Statement::All(const FunctionCallbackInfo<Value>& args) {
     return;
   }
 
+  THROW_AND_RETURN_ON_BAD_STATE(
+      env,
+      stmt->has_custom_functions_,
+      "Custom functions are not supported in async mode");
+
   Local<Promise::Resolver> resolver;
   if (StatementAsyncExecutionHelper::All(env, stmt).ToLocal(&resolver)) {
     args.GetReturnValue().Set(resolver->GetPromise());
@@ -2941,6 +2946,11 @@ void Statement::Get(const FunctionCallbackInfo<Value>& args) {
     return;
   }
 
+  THROW_AND_RETURN_ON_BAD_STATE(
+      env,
+      stmt->has_custom_functions_,
+      "Custom functions are not supported in async mode");
+
   Local<Promise::Resolver> resolver;
   if (StatementAsyncExecutionHelper::Get(env, stmt).ToLocal(&resolver)) {
     args.GetReturnValue().Set(resolver->GetPromise());
@@ -2972,6 +2982,11 @@ void Statement::Run(const FunctionCallbackInfo<Value>& args) {
     return;
   }
 
+  THROW_AND_RETURN_ON_BAD_STATE(
+      env,
+      stmt->has_custom_functions_,
+      "Custom functions are not supported in async mode");
+
   Local<Promise::Resolver> resolver;
   if (StatementAsyncExecutionHelper::Run(env, stmt).ToLocal(&resolver)) {
     args.GetReturnValue().Set(resolver->GetPromise());

src/node_sqlite.h

@@ -301,6 +301,7 @@ class Statement : public BaseObject {
   bool BindParams(const v8::FunctionCallbackInfo<v8::Value>& args);
   bool BindValue(const v8::Local<v8::Value>& value, const int index);
 
+  friend class Database;
   friend class StatementIterator;
   friend class SQLTagStore;
   friend class StatementExecutionHelper;