From cf2df5ba70e2dd8622bc0e6e476f2a9bd50ed77b Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Mon, 10 Mar 2025 14:16:52 -0300 Subject: [PATCH 1/2] fix: use messageonly type when notable-changes sec release Partially fixes: https://github.com/nodejs-private/security-release/issues/48 --- lib/prepare_release.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/prepare_release.js b/lib/prepare_release.js index 498b780e..854eedf0 100644 --- a/lib/prepare_release.js +++ b/lib/prepare_release.js @@ -481,7 +481,10 @@ export default class ReleasePreparation extends Session { const data = await fs.readFile(majorChangelogPath, 'utf8'); const arr = data.split('\n'); const allCommits = this.getChangelog(); - const notableChanges = await this.getBranchDiff({ onlyNotableChanges: true }); + const notableChanges = await this.getBranchDiff({ + onlyNotableChanges: true, + format: isSecurityRelease ? 'messageonly' : 'markdown', + }); let releaseHeader = `## ${date}, Version ${newVersion}` + ` ${releaseInfo}, @${username}\n`; if (isSecurityRelease) { From d010aab161995f730ddd17123178c9cbe4db99ff Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Mon, 10 Mar 2025 14:26:17 -0300 Subject: [PATCH 2/2] fix: adjust release commit message to messageonly on sec release Fixes: https://github.com/nodejs-private/security-release/issues/48 --- lib/prepare_release.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/prepare_release.js b/lib/prepare_release.js index 854eedf0..de77d2a4 100644 --- a/lib/prepare_release.js +++ b/lib/prepare_release.js @@ -622,7 +622,7 @@ export default class ReleasePreparation extends Session { const notableChanges = await this.getBranchDiff({ onlyNotableChanges: true, - format: 'plaintext' + format: isSecurityRelease ? 'messageonly' : 'plaintext' }); messageBody.push('Notable changes:\n\n'); if (isLTSTransition) {