Skip to content

Commit e5bf9de

Browse files
authored
Merge branch 'main' into tsconfig
2 parents 1ddb054 + 1716eb6 commit e5bf9de

File tree

12 files changed

+1169
-24
lines changed

12 files changed

+1169
-24
lines changed

PORTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Tests covering the engine-specific part of Node-API, defined in `js_native_api.h
5454
| `test_conversions` | Not ported | Medium |
5555
| `test_dataview` | Not ported | Medium |
5656
| `test_date` | Ported ✅ | Easy |
57-
| `test_error` | Not ported | Medium |
57+
| `test_error` | Ported ✅ | Medium |
5858
| `test_exception` | Not ported | Medium |
5959
| `test_finalizer` | Not ported | Medium |
6060
| `test_function` | Not ported | Medium |
@@ -71,7 +71,7 @@ Tests covering the engine-specific part of Node-API, defined in `js_native_api.h
7171
| `test_sharedarraybuffer` | Not ported | Medium |
7272
| `test_string` | Not ported | Medium |
7373
| `test_symbol` | Ported ✅ | Easy |
74-
| `test_typedarray` | Not ported | Medium |
74+
| `test_typedarray` | Ported ✅ | Medium |
7575

7676
## Runtime-specific (`node-api`)
7777

eslint.config.js

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
11
import { defineConfig, globalIgnores } from "eslint/config";
22
import globals from "globals";
3+
import eslint from '@eslint/js';
4+
import tseslint from 'typescript-eslint';
35

46
export default defineConfig([
5-
globalIgnores(["node"]),
7+
globalIgnores(["**/CMakeFiles/**"]),
8+
eslint.configs.recommended,
9+
tseslint.configs.recommended,
610
{
7-
files: ["tests/**/*.js"],
11+
files: [
12+
"tests/**/*.js",
13+
],
814
languageOptions: {
915
// Only allow ECMAScript built-ins and CTS harness globals.
1016
// This causes no-undef to flag any runtime-specific API (setTimeout, process, Buffer, etc.).
@@ -30,4 +36,16 @@ export default defineConfig([
3036
],
3137
},
3238
},
39+
{
40+
files: [
41+
"implementors/**/*.{js,ts}",
42+
"scripts/**/*.{js,mjs}",
43+
],
44+
languageOptions: {
45+
globals: {
46+
...globals.es2025,
47+
...globals.node,
48+
},
49+
},
50+
},
3351
]);

implementors/node/run-tests.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,6 @@ import { listDirectoryEntries, runFileInSubprocess } from "./tests.ts";
66
const ROOT_PATH = path.resolve(import.meta.dirname, "..", "..");
77
const TESTS_ROOT_PATH = path.join(ROOT_PATH, "tests");
88

9-
const ASSERT_MODULE_PATH = path.join(
10-
ROOT_PATH,
11-
"implementors",
12-
"node",
13-
"assert.js"
14-
);
15-
const LOAD_ADDON_MODULE_PATH = path.join(
16-
ROOT_PATH,
17-
"implementors",
18-
"node",
19-
"load-addon.js"
20-
);
21-
229
async function populateSuite(
2310
testContext: TestContext,
2411
dir: string

0 commit comments

Comments
 (0)