Skip to content

Commit b687765

Browse files
committed
fix incorrect behavior for -s and [variants] parameter
Signed-off-by: Harta Angkasa <24356946+ItsHarta@users.noreply.github.com>
1 parent faebb3d commit b687765

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

functions.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function get_variants() {
6969
if [ ${#variantsfilter[@]} -gt 0 ]; then
7070
for variant1 in "${availablevariants[@]}"; do
7171
for variant2 in "${variantsfilter[@]}"; do
72-
if [ "${variant1}" = "${variant2}" ]; then
72+
if [[ "${variant1}" =~ ^"${variant2}" ]]; then
7373
variants+=("${variant1}")
7474
fi
7575
done
@@ -365,4 +365,4 @@ function tests_updated() {
365365
return 1
366366
fi
367367
return 0
368-
}
368+
}

update.sh

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,14 @@ function update_node_version() {
130130
fi
131131

132132
nodeVersion="${version}.${fullVersion:-0}"
133+
134+
# preserve the existing YARN_VERSION
135+
if [ "${SKIP}" = true ] && [ -f "${dockerfile}" ]; then
136+
existing_yarn_version=$(grep -m1 'ENV YARN_VERSION=' "${dockerfile}" | cut -d'=' -f2 || echo "")
137+
if [ -n "${existing_yarn_version}" ]; then
138+
sed -Ei -e 's/^(ENV YARN_VERSION)=.*/\1='"${existing_yarn_version}"'/' "${dockerfile}-tmp"
139+
fi
140+
fi
133141

134142
sed -Ei -e 's/^FROM (.*)/FROM '"$fromprefix"'\1/' "${dockerfile}-tmp"
135143
sed -Ei -e 's/^(ENV NODE_VERSION)=.*/\1='"${nodeVersion}"'/' "${dockerfile}-tmp"
@@ -208,6 +216,11 @@ for version in "${versions[@]}"; do
208216
# Skip non-docker directories
209217
[ -f "${version}/${variant}/Dockerfile" ] || continue
210218

219+
# Skip alpine variants when SKIP is true
220+
if [ "${SKIP}" = true ] && is_alpine "${variant}"; then
221+
continue
222+
fi
223+
211224
update_variant=$(in_variants_to_update "${variant}")
212225
template_file="${parentpath}/Dockerfile-${variant}.template"
213226

0 commit comments

Comments
 (0)