tests: test that clone returns 4321

ethomson · ethomson · commit fe4efe2e36a2 · 2020-01-24T09:54:29.000-06:00
This conditional was backwards.  We should instead test that clone
returns 4321, not that 4321 returns clone.
diff --git a/tests/online/clone.c b/tests/online/clone.c
@@ -455,8 +455,8 @@ void test_online_clone__can_cancel(void)
 {
 	g_options.fetch_opts.callbacks.transfer_progress = cancel_at_half;
 
-	cl_git_fail_with(
-		git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options), 4321);
+	cl_git_fail_with(4321,
+		git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options));
 }
 
 static int cred_cb(git_cred **cred, const char *url, const char *user_from_url,

Original file line number	Diff line number	Diff line change
`@@ -455,8 +455,8 @@ void test_online_clone__can_cancel(void)`
`455`	`455`	`{`
`456`	`456`	`g_options.fetch_opts.callbacks.transfer_progress = cancel_at_half;`
`457`	`457`
`458`		`- cl_git_fail_with(`
`459`		`- git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options), 4321);`
	`458`	`+ cl_git_fail_with(4321,`
	`459`	`+ git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options));`
`460`	`460`	`}`
`461`	`461`
`462`	`462`	`static int cred_cb(git_cred *cred, const char url, const char *user_from_url,`