util: don't include unnecessary system libraries

ethomson · ethomson · commit fc42c28ebe8b · 2021-11-22T09:27:59.000-05:00
Remove some unnecessary includes from utility code.
diff --git a/src/date.c b/src/date.c
@@ -11,7 +11,6 @@
 #endif
 
 #include "util.h"
-#include "cache.h"
 #include "posix.h"
 #include "date.h"
 
diff --git a/src/fs_path.h b/src/fs_path.h
@@ -14,8 +14,6 @@
 #include "vector.h"
 #include "utf8.h"
 
-#include "git2/sys/path.h"
-
 /**
  * Path manipulation utils
  *
diff --git a/src/futils.c b/src/futils.c
@@ -15,6 +15,8 @@
 #include "win32/findfile.h"
 #endif
 
+#define GIT_FILEMODE_DEFAULT 0100666
+
 int git_futils_mkpath2file(const char *file_path, const mode_t mode)
 {
 	return git_futils_mkdir(
@@ -256,7 +258,7 @@ int git_futils_readbuffer(git_str *buf, const char *path)
 }
 
 int git_futils_writebuffer(
-	const git_str *buf,	const char *path, int flags, mode_t mode)
+	const git_str *buf, const char *path, int flags, mode_t mode)
 {
 	int fd, do_fsync = 0, error = 0;
 
@@ -269,7 +271,7 @@ int git_futils_writebuffer(
 	flags &= ~O_FSYNC;
 
 	if (!mode)
-		mode = GIT_FILEMODE_BLOB;
+		mode = GIT_FILEMODE_DEFAULT;
 
 	if ((fd = p_open(path, flags, mode)) < 0) {
 		git_error_set(GIT_ERROR_OS, "could not open '%s' for writing", path);
diff --git a/src/hash.h b/src/hash.h
@@ -10,7 +10,6 @@
 
 #include "common.h"
 
-#include "git2/oid.h"
 #include "hash/sha1.h"
 
 typedef struct {
diff --git a/src/net.c b/src/net.c
@@ -9,7 +9,6 @@
 #include "netops.h"
 
 #include <ctype.h>
-#include "git2/errors.h"
 
 #include "posix.h"
 #include "str.h"
diff --git a/src/unix/map.c b/src/unix/map.c
@@ -7,8 +7,6 @@
 
 #include "common.h"
 
-#include "git2/common.h"
-
 #if !defined(GIT_WIN32) && !defined(NO_MMAP)
 
 #include "map.h"
diff --git a/src/unix/posix.h b/src/unix/posix.h
@@ -7,9 +7,7 @@
 #ifndef INCLUDE_unix_posix_h__
 #define INCLUDE_unix_posix_h__
 
-#ifndef LIBGIT2_NO_FEATURES_H
-# include "git2/sys/features.h"
-#endif
+#include "common.h"
 
 #include <stdio.h>
 #include <dirent.h>
diff --git a/src/unix/realpath.c b/src/unix/realpath.c
@@ -7,8 +7,6 @@
 
 #include "common.h"
 
-#include "git2/common.h"
-
 #ifndef GIT_WIN32
 
 #include <limits.h>
diff --git a/tests/core/copy.c b/tests/core/copy.c
@@ -1,6 +1,5 @@
 #include "clar_libgit2.h"
 #include "futils.h"
-#include "path.h"
 #include "posix.h"
 
 void test_core_copy__file(void)
diff --git a/tests/core/env.c b/tests/core/env.c
@@ -1,7 +1,6 @@
 #include "clar_libgit2.h"
 #include "futils.h"
 #include "sysdir.h"
-#include "path.h"
 
 #ifdef GIT_WIN32
 #define NUM_VARS 5
diff --git a/tests/core/link.c b/tests/core/link.c
@@ -1,6 +1,5 @@
 #include "clar_libgit2.h"
 #include "posix.h"
-#include "path.h"
 
 #ifdef GIT_WIN32
 # include "win32/reparse.h"
diff --git a/tests/core/mkdir.c b/tests/core/mkdir.c
@@ -1,6 +1,5 @@
 #include "clar_libgit2.h"
 #include "futils.h"
-#include "path.h"
 #include "posix.h"
 
 static void cleanup_basic_dirs(void *ref)
diff --git a/tests/core/stat.c b/tests/core/stat.c
@@ -1,6 +1,5 @@
 #include "clar_libgit2.h"
 #include "futils.h"
-#include "path.h"
 #include "posix.h"
 
 void test_core_stat__initialize(void)
diff --git a/tests/path/win32.c b/tests/path/win32.c
@@ -1,6 +1,5 @@
 
 #include "clar_libgit2.h"
-#include "path.h"
 
 #ifdef GIT_WIN32
 #include "win32/path_w32.h"

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,6 @@`
`14`	`14`	`#include "vector.h"`
`15`	`15`	`#include "utf8.h"`
`16`	`16`
`17`		`-#include "git2/sys/path.h"`
`18`		`-`
`19`	`17`	`/**`
`20`	`18`	`* Path manipulation utils`
`21`	`19`	`*`